Only warn about empty aesthetics when data size is known (#6690)

* move warning about empty aesthetics

* test for warning during build phase

Author: teunbrand

R/layer.R

@@ -142,15 +142,6 @@ layer <- function(geom = NULL, stat = NULL,
   if (any(pattern)) {
     aes_params[pattern] <- lapply(aes_params[pattern], list)
   }
-  # Drop empty aesthetics
-  empty_aes <- names(aes_params)[lengths(aes_params) == 0]
-  if (length(empty_aes) > 0) {
-    cli::cli_warn(
-      "Ignoring empty aesthetic{?s}: {.arg {empty_aes}}.",
-      call = call_env
-    )
-    aes_params <- aes_params[setdiff(names(aes_params), empty_aes)]
-  }
 
   # Warn about extra params and aesthetics
   extra_param <- setdiff(names(params), all)
@@ -786,6 +777,16 @@ Layer <- ggproto("Layer", NULL,
     # Combine aesthetics, defaults, & params
     if (empty(data)) return(data)
 
+    # Drop empty aesthetics
+    empty_aes <- names(params)[lengths(params) == 0]
+    if (length(empty_aes) > 0) {
+      cli::cli_warn(
+        "Ignoring empty aesthetic{?s}: {.arg {empty_aes}}.",
+        call = self$constructor
+      )
+      params <- params[setdiff(names(params), empty_aes)]
+    }
+
     aesthetics <- self$computed_mapping
     modifiers <- aesthetics[is_scaled_aes(aesthetics) | is_staged_aes(aesthetics) | is_themed_aes(aesthetics)]
 

tests/testthat/test-layer.R

@@ -29,7 +29,8 @@ test_that("unknown aesthetics create warning", {
 })
 
 test_that("empty aesthetics create warning", {
-  expect_snapshot_warning(geom_point(fill = NULL, shape = character()))
+  p <- ggplot(mtcars) + geom_point(aes(disp, mpg), fill = NULL, shape = character())
+  expect_snapshot_warning(ggplot_build(p))
 })
 
 test_that("invalid aesthetics throws errors", {