Simplify env files, merge to one .env #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusevyaroslove
pushed a commit
to gusevyaroslove/fastapi-template
that referenced
this pull request
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Simplify env files, merge to one
.env.Having multiple files for env variables could help to identify which configs belong to which services, but the same can be done with comments.
A single
.envfile could help to have a general idea of all the configs in a single place.It will also help to simplify the development of the project generator itself, as env var templates now live in a single file that can be generated more easily.
Having files separated could help if there were conflicts between env var names for different services, but that's not the case. The other reason would be to not expose env vars to some services if they were not trusted, but that's also not the case here, all the services in this stack are part of the app itself and "trusted", so they can get the env vars, they just won't use them.