Fix crash in RCTJSStackFrame::stackFrameWithDictionary:

terribleben · thotegowda · commit 2d7975653508 · 2017-05-07T11:26:35.000+05:30
Summary: Motivation: When logging to RCTRedBox, if any of the stack frames lacks a line number or a column, the application will crash with `[NSNull integerValue]: unrecognized selector sent to instance`. Closes facebook#13242 Differential Revision: D4812185 Pulled By: hramos fbshipit-source-id: 4b1c3c38f67cf59034a383c95d4280d1b6380300
diff --git a/React/Base/RCTJSStackFrame.m b/React/Base/RCTJSStackFrame.m
@@ -70,8 +70,8 @@ + (instancetype)stackFrameWithDictionary:(NSDictionary *)dict
 {
   return [[self alloc] initWithMethodName:dict[@"methodName"]
                                      file:dict[@"file"]
-                               lineNumber:[dict[@"lineNumber"] integerValue]
-                                   column:[dict[@"column"] integerValue]];
+                               lineNumber:[RCTNilIfNull(dict[@"lineNumber"]) integerValue]
+                                   column:[RCTNilIfNull(dict[@"column"]) integerValue]];
 }
 
 + (NSArray<RCTJSStackFrame *> *)stackFramesWithLines:(NSString *)lines

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,8 @@ + (instancetype)stackFrameWithDictionary:(NSDictionary *)dict`
`70`	`70`	`{`
`71`	`71`	`return [[self alloc] initWithMethodName:dict[@"methodName"]`
`72`	`72`	`file:dict[@"file"]`
`73`		`- lineNumber:[dict[@"lineNumber"] integerValue]`
`74`		`- column:[dict[@"column"] integerValue]];`
	`73`	`+ lineNumber:[RCTNilIfNull(dict[@"lineNumber"]) integerValue]`
	`74`	`+ column:[RCTNilIfNull(dict[@"column"]) integerValue]];`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`+ (NSArray<RCTJSStackFrame > )stackFramesWithLines:(NSString *)lines`