Skip to content

[ react-v2.1.10-alpha.4]: fix - Build error with React package #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

mahmud-bn
Copy link
Contributor

@mahmud-bn mahmud-bn commented Jun 18, 2022

Description

Fixes React's useSyncExternalStore Hook build error that occurs with some JS bundler/frameworks.
Related Issue #1055

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@taylorjdawson
Copy link
Contributor

@mahmud-bn Why does it need to be imported like that?

@mahmud-bn
Copy link
Contributor Author

@mahmud-bn Why does it need to be imported like that?

@taylorjdawson It's a solution for the ESM issue #1055

@mahmud-bn mahmud-bn requested a review from taylorjdawson June 20, 2022 18:29
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works locally! LGTM!!

@mahmud-bn mahmud-bn merged commit 3b5c25b into v2-web3-onboard-develop Jun 20, 2022
@Adamj1232 Adamj1232 mentioned this pull request Jun 21, 2022
4 tasks
@Adamj1232 Adamj1232 deleted the fix/react-shim branch January 26, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants