Skip to content

Remove "starter" plan checks from team invitation logic #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jul 2, 2025

PR-Codex overview

This PR focuses on updating the logic for team member invitations and modifying the pricing options in the dashboard. It simplifies conditions for enabling invites and removes an invitation option from the pricing list.

Detailed summary

  • Removed "Invite Team Members" from the pricing options in pricing.tsx.
  • Simplified the condition for showing the invite button in InviteTeamMembers.tsx to only check for the "free" billing plan.
  • Updated the invite enabling logic in InviteSection.tsx to remove the "starter" plan condition.
  • Adjusted the conditional check for the bottom section display in InviteSection.tsx to only check for the "free" plan.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Updated team plan features by removing "Invite Team Members" from the "growth" plan feature list.
  • Bug Fixes

    • Adjusted upgrade prompts and invite functionality so that upgrade options and invite restrictions now apply only to teams on the "free" plan, rather than both "free" and "starter" plans.

@vercel vercel bot temporarily deployed to Preview – nebula July 2, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 2, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 2, 2025 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 2, 2025 18:36 Inactive
Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 6:59pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 2, 2025 6:59pm
nebula ⬜️ Skipped (Inspect) Jul 2, 2025 6:59pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 2, 2025 6:59pm
wallet-ui ⬜️ Skipped (Inspect) Jul 2, 2025 6:59pm

Copy link

changeset-bot bot commented Jul 2, 2025

⚠️ No Changeset found

Latest commit: bde53fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jul 2, 2025

Walkthrough

The changes update the team plan features and adjust the logic for displaying invite-related UI elements. Specifically, the "Invite Team Members" feature was removed from the "growth" plan, and conditions for showing upgrade prompts and enabling invites now only consider the "free" plan, excluding the "starter" plan from these checks.

Changes

File(s) Change Summary
apps/dashboard/src/@/utils/pricing.tsx Removed "Invite Team Members" from the "growth" team plan's feature list.
apps/dashboard/src/app/(app)/login/onboarding/team-onboarding/InviteTeamMembers.tsx Changed upgrade button visibility to show only for "free" billing plan (not "starter" or "free").
apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/members/InviteSection.tsx Simplified invite enabling and UI rendering logic to check only for "free" plan, not "free" or "starter".

Possibly related PRs

Suggested reviewers

  • jnsdls
  • MananTank

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74e8d04 and bde53fc.

📒 Files selected for processing (3)
  • apps/dashboard/src/@/utils/pricing.tsx (0 hunks)
  • apps/dashboard/src/app/(app)/login/onboarding/team-onboarding/InviteTeamMembers.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/members/InviteSection.tsx (2 hunks)
💤 Files with no reviewable changes (1)
  • apps/dashboard/src/@/utils/pricing.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/dashboard/src/app/(app)/login/onboarding/team-onboarding/InviteTeamMembers.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/members/InviteSection.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Lint Packages
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Build Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 2, 2025
Copy link
Member Author

jnsdls commented Jul 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls force-pushed the Remove_starter_plan_checks_from_team_invitation_logic branch from f3e3796 to 74e8d04 Compare July 2, 2025 18:37
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 2, 2025 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 2, 2025 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 2, 2025 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 2, 2025 18:37 Inactive
@jnsdls jnsdls marked this pull request as ready for review July 2, 2025 18:37
@jnsdls jnsdls requested review from a team as code owners July 2, 2025 18:37
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.96%. Comparing base (7437289) to head (bde53fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7513   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files         952      952           
  Lines       64224    64224           
  Branches     4237     4237           
=======================================
  Hits        33377    33377           
  Misses      30740    30740           
  Partials      107      107           
Flag Coverage Δ
packages 51.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 2.4 s (-6.19% 🔽) 3.7 s
thirdweb (cjs) 352.76 KB (0%) 7.1 s (0%) 18 s (+2.31% 🔺) 25.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 189 ms (+3.83% 🔺) 304 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 84 ms (+13.03% 🔺) 95 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 386 ms (+13.11% 🔺) 778 ms

Copy link
Contributor

graphite-app bot commented Jul 2, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on refining the invitation feature within the onboarding and settings sections of the application. It simplifies the conditions for inviting team members based on the billing plan.

### Detailed summary
- Removed `"Invite Team Members"` from the pricing options in `pricing.tsx`.
- Updated the conditional rendering for the custom CTA in `InviteTeamMembers.tsx` to check only for the `"free"` billing plan.
- Simplified the `inviteEnabled` condition in `InviteSection.tsx` to exclude the `"starter"` plan.
- Adjusted the conditional check for displaying the bottom section in `InviteSection.tsx` to only check for the `"free"` plan.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **New Features**
  * Updated team plan features by removing "Invite Team Members" from the "growth" plan feature list.

* **Bug Fixes**
  * Adjusted upgrade prompts and invite functionality so that upgrade options and invite restrictions now apply only to teams on the "free" plan, rather than both "free" and "starter" plans.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the Remove_starter_plan_checks_from_team_invitation_logic branch from 74e8d04 to bde53fc Compare July 2, 2025 18:51
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 2, 2025 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 2, 2025 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 2, 2025 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 2, 2025 18:51 Inactive
@graphite-app graphite-app bot merged commit bde53fc into main Jul 2, 2025
24 checks passed
@graphite-app graphite-app bot deleted the Remove_starter_plan_checks_from_team_invitation_logic branch July 2, 2025 19:00
@vercel vercel bot temporarily deployed to Production – docs-v2 July 2, 2025 19:00 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui July 2, 2025 19:00 Inactive
@vercel vercel bot temporarily deployed to Production – nebula July 2, 2025 19:00 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground July 2, 2025 19:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants