-
Notifications
You must be signed in to change notification settings - Fork 559
Version Packages #7453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7453
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis update increments patch versions for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TransactionWidget
participant UI
User ->> TransactionWidget: Initiate transaction with token
TransactionWidget -->> UI: Check token support
alt Token unsupported
TransactionWidget -->> UI: Display "Unsupported Token" fallback screen
else Token supported
TransactionWidget -->> UI: Proceed with transaction flow
end
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Changelog entry is missing contextEvery released version should briefly explain why the bump happened (e.g. “dependency updates only”).
Consider adding a “### Patch Changes” section – even if it just notes that the version was bumped to stay in sync withthirdweb 5.105.2
.packages/thirdweb/CHANGELOG.md (1)
3-8
: Optional: add release date for consistencyPrevious entries often include the publication date; adding it here keeps the changelog uniform and helps users track releases chronologically.
-## 5.105.2 +## 5.105.2 – 2025-06-??packages/nebula/CHANGELOG.md (1)
3-9
: Consider briefly noting the end-user impact of the dependency bumpThe entry accurately records the version change and links the commit, but readers scanning the changelog may miss that the
[email protected]
update introduces the “Unsupported Token” fallback screen inTransactionWidget
. A one-line note after the bullet (e.g., “Adds fallback screen for unsupported tokens in TransactionWidget”) would make the practical benefit of upgrading clearer at a glance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/crazy-bushes-stick.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/crazy-bushes-stick.md
🧰 Additional context used
📓 Path-based instructions (2)
`packages/wagmi-adapter/*`: Wagmi ecosystem integration is located in packages/wagmi-adapter/.
packages/wagmi-adapter/*
: Wagmi ecosystem integration is located in packages/wagmi-adapter/.
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/wagmi-adapter/package.json
packages/wagmi-adapter/CHANGELOG.md
`packages/thirdweb/*`: Every public symbol in the SDK must have comprehensive TS...
packages/thirdweb/*
: Every public symbol in the SDK must have comprehensive TSDoc with at least one @example block that compiles and custom annotation tags (@beta, @internal, @experimental).
Export everything via the exports/ directory, grouped by feature.
Place tests alongside code: foo.ts ↔ foo.test.ts.
Use real function invocations with stub data in tests; avoid brittle mocks.
Use Mock Service Worker (MSW) for fetch/HTTP call interception in tests.
Keep tests deterministic and side-effect free.
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/thirdweb/package.json
packages/thirdweb/CHANGELOG.md
🧠 Learnings (3)
packages/wagmi-adapter/package.json (1)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/wagmi-adapter/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-25T02:13:08.257Z
Learning: For multi-platform support, provide platform-specific exports and adapters (e.g., React Native, Node.js, Wagmi, Ethers).
packages/thirdweb/package.json (1)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/wagmi-adapter/package.json (1)
58-58
: Double-check peer-dependency floor
peerDependencies.thirdweb
is still^5.85.0
, which technically allows 5.105.2, but readers might assume the adapter is tested only from 5.85 upward.
If the bump to 0.2.99 is specifically to align with 5.105.2, consider raising the minimum to^5.105.0
(or leave a comment explaining compatibility).packages/thirdweb/package.json (1)
407-407
: Version bump LGTMPatch version increment from
5.105.1
→5.105.2
follows semver and aligns with the changelog entry added elsewhere in the PR.packages/nebula/package.json (1)
3-3
: Nebula version bump LGTM
0.2.1
→0.2.2
is consistent with the dependency update to[email protected]
and changelog notes.
|
||
### Patch Changes | ||
|
||
- [#7452](https://github.com/thirdweb-dev/js/pull/7452) [`277c2e2`](https://github.com/thirdweb-dev/js/commit/277c2e2ed96ff38194a2d5c33916d25a8f1e9a6f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Adds "Unsupported Token" fallback screen to TransactionWidget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR reference appears incorrect – verify before merge
The changelog links to PR #7452, but this release is being delivered by PR #7453.
Please confirm the intended reference and update the number (and URL) if necessary to avoid confusion for downstream consumers and maintainers.
- - [#7452](https://github.com/thirdweb-dev/js/pull/7452) ...
+ - [#7453](https://github.com/thirdweb-dev/js/pull/7453) ...
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- [#7452](https://github.com/thirdweb-dev/js/pull/7452) [`277c2e2`](https://github.com/thirdweb-dev/js/commit/277c2e2ed96ff38194a2d5c33916d25a8f1e9a6f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Adds "Unsupported Token" fallback screen to TransactionWidget | |
- [#7453](https://github.com/thirdweb-dev/js/pull/7453) [`277c2e2`](https://github.com/thirdweb-dev/js/commit/277c2e2ed96ff38194a2d5c33916d25a8f1e9a6f) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Adds "Unsupported Token" fallback screen to TransactionWidget |
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md at line 7, the PR reference number and URL are
incorrect; they show #7452 instead of the correct PR #7453. Update the PR number
and corresponding URL to #7453 to accurately reflect the release source and
avoid confusion.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7453 +/- ##
=======================================
Coverage 51.90% 51.90%
=======================================
Files 947 947
Lines 63932 63932
Branches 4209 4209
=======================================
Hits 33186 33186
Misses 30640 30640
Partials 106 106
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
27b46aa
to
c721300
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
277c2e2
,c2ef5eb
]:[email protected]
Patch Changes
#7452
277c2e2
Thanks @gregfromstl! - Adds "Unsupported Token" fallback screen to TransactionWidget#7451
c2ef5eb
Thanks @joaquim-verges! - update dependencies@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers and changelogs for several packages, along with dependency updates and notable feature additions.
Detailed summary
.changeset/crazy-bushes-stick.md
and.changeset/fluffy-books-hammer.md
.version
inpackages/thirdweb/package.json
from5.105.1
to5.105.2
.version
inpackages/wagmi-adapter/package.json
from0.2.98
to0.2.99
.version
inpackages/nebula/package.json
from0.2.1
to0.2.2
.packages/nebula
version0.2.2
with updated dependencies.packages/thirdweb
version5.105.2
with new features and dependency updates.Summary by CodeRabbit
New Features
Chores