Skip to content

Fix: Include correct client in payment link UI #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Jun 26, 2025

FIXES TOOL-4882 TOOL-4881


PR-Codex overview

This PR focuses on replacing the PayPageEmbed component with the PayPageWidget component in various files related to the payment functionality. It also introduces the new PayPageWidget component with additional features and hooks for enhanced functionality.

Detailed summary

  • Deleted PayPageEmbed component references in PayPageEmbed.client.tsx and updated imports to PayPageWidget.
  • Updated PayPage function in page.tsx to use PayPageWidget instead of PayPageEmbed.
  • Created a new PayPageWidget component in PayPageWidget.client.tsx with:
    • Props for payment details and UI customization.
    • Integration of AutoConnect and CheckoutWidget from thirdweb.
    • Theme handling using useTheme and useEffect.
    • Improved payment processing and redirect handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Introduced a new payment checkout widget for processing payments.
  • Refactor

    • Replaced the previous payment embed component with the new payment widget for a streamlined payment experience.

@gregfromstl gregfromstl requested review from a team as code owners June 26, 2025 17:51
Copy link

linear bot commented Jun 26, 2025

Copy link

changeset-bot bot commented Jun 26, 2025

⚠️ No Changeset found

Latest commit: ce0f0d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2025 6:13pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 26, 2025 6:13pm
nebula ⬜️ Skipped (Inspect) Jun 26, 2025 6:13pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 26, 2025 6:13pm
wallet-ui ⬜️ Skipped (Inspect) Jun 26, 2025 6:13pm

Copy link
Contributor

coderabbitai bot commented Jun 26, 2025

"""

Walkthrough

The code replaces the usage of the PayPageEmbed component with a new PayPageWidget component for rendering payment UIs. The old embed component is deleted, and the new widget is imported and used in relevant pages. The new widget handles payment link ID and client ID as props, updating the payment checkout flow accordingly.

Changes

Files/Paths Change Summary
.../pay/components/client/PayPageEmbed.client.tsx Deleted the PayPageEmbed React component.
.../pay/components/client/PayPageWidget.client.tsx Added new PayPageWidget React component for payment checkout using thirdweb SDK.
.../pay/[id]/page.tsx, .../pay/page.tsx Updated import and usage from PayPageEmbed to PayPageWidget.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PayPage
    participant PayPageWidget
    participant AutoConnect
    participant CheckoutWidget

    User->>PayPage: Visit payment page
    PayPage->>PayPageWidget: Render with payment props
    PayPageWidget->>AutoConnect: Initialize wallet connection
    AutoConnect->>CheckoutWidget: Render checkout UI with payment details
    CheckoutWidget-->>User: Display payment interface
    User->>CheckoutWidget: Complete payment
    CheckoutWidget->>PayPageWidget: Notify onSuccess
    PayPageWidget->>User: Redirect or show confirmation
Loading

Assessment against linked issues

Objective Addressed Explanation
Include Payment Link ID in CheckoutWidget (TOOL-4882)
Pass Query Param Client ID to Payment Link CheckoutWidget (TOOL-4881)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related PRs

Suggested labels

packages, SDK

Suggested reviewers

  • jnsdls
    """

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bad2bc5 and ce0f0d2.

📒 Files selected for processing (4)
  • apps/dashboard/src/app/pay/[id]/page.tsx (2 hunks)
  • apps/dashboard/src/app/pay/components/client/PayPageEmbed.client.tsx (0 hunks)
  • apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (1 hunks)
  • apps/dashboard/src/app/pay/page.tsx (2 hunks)
💤 Files with no reviewable changes (1)
  • apps/dashboard/src/app/pay/components/client/PayPageEmbed.client.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/app/pay/[id]/page.tsx
  • apps/dashboard/src/app/pay/page.tsx
  • apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

graphite-app bot commented Jun 26, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (102a8c8) to head (ce0f0d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7449   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files         947      947           
  Lines       63875    63875           
  Branches     4214     4214           
=======================================
  Hits        33166    33166           
  Misses      30603    30603           
  Partials      106      106           
Flag Coverage Δ
packages 51.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregfromstl gregfromstl force-pushed the greg/tool-4881-pass-query-param-client-id-to-payment-link-checkoutwidget branch from dc836b6 to bad2bc5 Compare June 26, 2025 17:54
@vercel vercel bot temporarily deployed to Preview – nebula June 26, 2025 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 26, 2025 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 26, 2025 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 26, 2025 17:54 Inactive
Copy link
Contributor

github-actions bot commented Jun 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.75 KB (0%) 1.3 s (0%) 385 ms (+79.08% 🔺) 1.7 s
thirdweb (cjs) 351.77 KB (0%) 7.1 s (0%) 1.8 s (+0.78% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 121 ms (+611.9% 🔺) 236 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 39 ms (+544.15% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.61 KB (0%) 393 ms (0%) 104 ms (+247.09% 🔺) 496 ms

@gregfromstl gregfromstl force-pushed the greg/tool-4881-pass-query-param-client-id-to-payment-link-checkoutwidget branch from bad2bc5 to ce0f0d2 Compare June 26, 2025 18:04
@vercel vercel bot temporarily deployed to Preview – nebula June 26, 2025 18:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 26, 2025 18:04 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 26, 2025 18:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 26, 2025 18:04 Inactive
@gregfromstl gregfromstl merged commit 45bb790 into main Jun 26, 2025
24 checks passed
@gregfromstl gregfromstl deleted the greg/tool-4881-pass-query-param-client-id-to-payment-link-checkoutwidget branch June 26, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant