[SDK] Fix: Deprecate test mode #7396

gregfromstl · 2025-06-20T20:05:53Z

PR-Codex overview

This PR introduces deprecation notices for the testMode property in two types within the ConnectButtonProps.ts file, signaling that these properties should no longer be used.

Detailed summary

Added a @deprecated comment to the testMode property in the first instance.
Added a @deprecated comment to the testMode property in the buyWithFiat options.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Documentation
- Marked the testMode option as deprecated in both buyWithCrypto and buyWithFiat payment settings.

changeset-bot · 2025-06-20T20:05:57Z

⚠️ No Changeset found

Latest commit: 5a5f4f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-06-20T20:05:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 8:07pm
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 8:07pm
nebula	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 8:07pm
thirdweb_playground	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 8:07pm
thirdweb-www	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 8:07pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 20, 2025 8:07pm

coderabbitai · 2025-06-20T20:05:59Z

Walkthrough

The change adds a JSDoc @deprecated annotation to the testMode property within both the buyWithCrypto and buyWithFiat objects of the PayUIOptions type, indicating that this property is deprecated in these contexts. No other modifications are made.

Changes

File	Change Summary
packages/thirdweb/src/react/core/hooks/connection/ConnectButtonProps.ts	Added `@deprecated` JSDoc annotation to `testMode` in `PayUIOptions`.

Suggested labels

packages, SDK

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

graphite-app · 2025-06-20T20:05:59Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/thirdweb/src/react/core/hooks/connection/ConnectButtonProps.ts (2)
80-83: Enhance deprecation annotation with context
The @deprecated tag is correctly applied to buyWithCrypto.testMode, but it lacks details such as the deprecation version, removal timeline, or recommended alternative. Please enrich the JSDoc, for example:
/**
 * @deprecated since vX.Y — testMode is no longer supported and will be removed in vZ. Use <alternativeOption> instead.
 */
testMode?: boolean;
101-104: Apply consistent deprecation messaging for fiat flow
Mirror the enhanced deprecation notice for buyWithFiat.testMode to ensure both payment options provide the same guidance.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c420c0 and 5a5f4f8.

📒 Files selected for processing (1)

packages/thirdweb/src/react/core/hooks/connection/ConnectButtonProps.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Unit Tests
GitHub Check: Analyze (javascript)

github-actions · 2025-06-20T20:11:43Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	62.53 KB (0%)	1.3 s (0%)	297 ms (+162.81% 🔺)	1.6 s
thirdweb (cjs)	350.55 KB (0%)	7.1 s (0%)	1.1 s (+15.73% 🔺)	8.1 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	98 ms (+1384.85% 🔺)	212 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	86 ms (+3829.5% 🔺)	96 ms
thirdweb/react (minimal + tree-shaking)	19.6 KB (+0.07% 🔺)	393 ms (+0.07% 🔺)	129 ms (+726.59% 🔺)	521 ms

codecov · 2025-06-20T20:11:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.19%. Comparing base (9c420c0) to head (5a5f4f8).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7396      +/-   ##
==========================================
- Coverage   52.20%   52.19%   -0.01%     
==========================================
  Files         945      945              
  Lines       63578    63578              
  Branches     4229     4227       -2     
==========================================
- Hits        33192    33186       -6     
- Misses      30279    30285       +6     
  Partials      107      107

Flag	Coverage Δ
packages	`52.19% <ø> (-0.01%)`	⬇️

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fix: deprecate test mode

5a5f4f8

gregfromstl requested review from a team as code owners June 20, 2025 20:05

github-actions bot assigned gregfromstl Jun 20, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jun 20, 2025

coderabbitai bot reviewed Jun 20, 2025

View reviewed changes

vercel bot deployed to Preview – login June 20, 2025 20:07 View deployment

vercel bot deployed to Preview – wallet-ui June 20, 2025 20:07 View deployment

vercel bot deployed to Preview – nebula June 20, 2025 20:07 View deployment

gregfromstl merged commit 9fec4cc into main Jun 20, 2025
18 of 20 checks passed

gregfromstl deleted the greg/deprecate-test-mode branch June 20, 2025 20:07

vercel bot deployed to Preview – thirdweb_playground June 20, 2025 20:08 View deployment

vercel bot deployed to Preview – thirdweb-www June 20, 2025 20:14 View deployment

vercel bot deployed to Preview – docs-v2 June 20, 2025 20:16 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Fix: Deprecate test mode #7396

[SDK] Fix: Deprecate test mode #7396

Uh oh!

gregfromstl commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jun 20, 2025

Uh oh!

vercel bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

graphite-app bot commented Jun 20, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

codecov bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

[SDK] Fix: Deprecate test mode #7396

[SDK] Fix: Deprecate test mode #7396

Uh oh!

Conversation

gregfromstl commented Jun 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jun 20, 2025

⚠️ No Changeset found

Uh oh!

vercel bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

graphite-app bot commented Jun 20, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 20, 2025

size-limit report 📦

Uh oh!

codecov bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

gregfromstl commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 20, 2025 •

edited

Loading

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jun 20, 2025 •

edited

Loading