Skip to content

[Dashboard] Disable 7-day trial for growth plan #7392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 20, 2025

Disabled 7-day trial period for new growth plan users

Previously, users who signed up for the growth plan would automatically receive a 7-day trial period. This PR disables this functionality by setting has7DayTrial to false with a comment indicating that trials are temporarily disabled.

Summary by CodeRabbit

  • Refactor
    • Disabled the 7-day free trial feature for all users.

Copy link

vercel bot commented Jun 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 7:22am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 20, 2025 7:22am
login ⬜️ Skipped (Inspect) Jun 20, 2025 7:22am
nebula ⬜️ Skipped (Inspect) Jun 20, 2025 7:22am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 20, 2025 7:22am
wallet-ui ⬜️ Skipped (Inspect) Jun 20, 2025 7:22am

@vercel vercel bot temporarily deployed to Preview – login June 20, 2025 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 20, 2025 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 20, 2025 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 20, 2025 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 20, 2025 07:14 Inactive
Copy link

changeset-bot bot commented Jun 20, 2025

⚠️ No Changeset found

Latest commit: 254f29c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 20, 2025

Walkthrough

The logic that previously determined eligibility for a 7-day free trial in the pricing card component has been removed. The relevant variable is now set to always be false, disabling the 7-day trial feature regardless of any billing or plan status.

Changes

File(s) Change Summary
apps/dashboard/src/@/components/blocks/pricing-card.tsx Replaced conditional logic for 7-day trial eligibility with a constant false value.

Possibly related PRs

Suggested reviewers

  • MananTank

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f56cc00 and 254f29c.

📒 Files selected for processing (1)
  • apps/dashboard/src/@/components/blocks/pricing-card.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Unit Tests
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/dashboard/src/@/components/blocks/pricing-card.tsx (1)

63-64: Verify scope: change affects all plans, not just growth plan.

The implementation disables the 7-day trial for all billing plans, but the PR objective specifically mentions disabling it "for growth plan" only. Please confirm if this broader scope is intentional.

The current implementation is clean and will work correctly, but if you need to target only the growth plan, consider:

- // trials are disabled for now
- const has7DayTrial = false;
+ // trials are disabled for growth plan
+ const has7DayTrial = billingPlan !== 'growth' && 
+   remainingTrialDays === 0 && 
+   billingStatus === 'noPayment' && 
+   billingPlan === 'growth'; // This would always be false due to the first condition, but keeping original logic structure

Or more simply for growth-only disable:

- // trials are disabled for now
- const has7DayTrial = false;
+ // trials are disabled for growth plan
+ const has7DayTrial = billingPlan !== 'growth' && [original conditions];
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 20, 2025
Copy link
Member Author

jnsdls commented Jun 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review June 20, 2025 07:15
@jnsdls jnsdls requested review from a team as code owners June 20, 2025 07:15
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.53 KB (0%) 1.3 s (0%) 419 ms (+109.49% 🔺) 1.7 s
thirdweb (cjs) 350.55 KB (0%) 7.1 s (0%) 1.5 s (-3.67% 🔽) 8.5 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 220 ms (+1761.62% 🔺) 333 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 71 ms (+1416.91% 🔺) 81 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 161 ms (+408.88% 🔺) 553 ms

@jnsdls jnsdls merged commit ffea73c into main Jun 20, 2025
24 of 25 checks passed
@jnsdls jnsdls deleted the _Dashboard_Disable_7-day_trial_for_growth_plan branch June 20, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant