[TOOL-4831] SDK: Fix MediaRenderer not showing poster for 3d models #7387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 70e024f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
""" WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MediaRenderer
participant ImageRenderer
User->>MediaRenderer: Render media (may be 3D model)
alt Media type is 3D model
MediaRenderer->>MediaRenderer: Check for poster image
alt Poster image exists
MediaRenderer->>ImageRenderer: Render poster image
else Poster image missing
MediaRenderer->>MediaRenderer: Log error, render fallback UI
end
else Media type not 3D model
MediaRenderer->>MediaRenderer: Render media as usual
end
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7387 +/- ##
==========================================
+ Coverage 52.35% 52.42% +0.06%
==========================================
Files 939 939
Lines 63161 63173 +12
Branches 4217 4223 +6
==========================================
+ Hits 33070 33116 +46
+ Misses 29984 29950 -34
Partials 107 107
🚀 New features to boost your workflow:
|
gregfromstl
approved these changes
Jun 19, 2025
MananTank
force-pushed
the
06-19-_tool-4831_sdk_fix_mediarenderer_not_showing_poster_for_3d_models
branch
from
8943361 to
4495fb9
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/heavy-ghosts-nail.md(1 hunks)packages/thirdweb/src/react/web/ui/MediaRenderer/MediaRenderer.test.tsx(3 hunks)packages/thirdweb/src/react/web/ui/MediaRenderer/MediaRenderer.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- .changeset/heavy-ghosts-nail.md
- packages/thirdweb/src/react/web/ui/MediaRenderer/MediaRenderer.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/thirdweb/src/react/web/ui/MediaRenderer/MediaRenderer.test.tsx (2)
17-20: LGTM! Good refactoring for maintainability.The addition of constants for test URLs improves code readability and maintainability by eliminating hardcoded URLs in multiple places.
36-36: LGTM! Consistent use of the new constant.Good refactoring to use the new
imageLinkconstant instead of the hardcoded URL.
packages/thirdweb/src/react/web/ui/MediaRenderer/MediaRenderer.test.tsx
Outdated
Show resolved
Hide resolved
MananTank
force-pushed
the
06-19-_tool-4831_sdk_fix_mediarenderer_not_showing_poster_for_3d_models
branch
from
4495fb9 to
b6d2ab7
Compare
Merge activity
|
…7387) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on fixing the display of the `poster` in the `MediaRenderer` component for 3D models and adding tests to ensure expected behavior. ### Detailed summary - Updated the `MediaRenderer` component to show a `poster` image for 3D models. - Added a new test case to verify rendering of the `poster` image when a 3D model is provided. - Replaced hardcoded image URL with a constant `imageLink` for clarity in tests. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Fixed an issue where the poster image was not displayed when rendering 3D models in the MediaRenderer component. Now, if a poster image is available, it will be shown as a fallback for unsupported 3D models. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
06-19-_tool-4831_sdk_fix_mediarenderer_not_showing_poster_for_3d_models
branch
from
b6d2ab7 to
70e024f
Compare
graphite-app
bot
deleted the
06-19-_tool-4831_sdk_fix_mediarenderer_not_showing_poster_for_3d_models
branch
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on fixing the issue where the
posterimage was not displayed in theMediaRenderercomponent for 3D models. It also updates the tests to reflect this new functionality.Detailed summary
posterimage for 3D models in theMediaRenderercomponent.MediaRendererto include a test case for rendering a poster image when a 3D model is provided.Summary by CodeRabbit