Fix: Bridge Playground Chain Input Form #7371
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes update an input field for "Chain ID" in the playground web app from a number to a text input. Separately, the PaymentReceipt component in the thirdweb package now tracks and displays destination chain metadata in transaction info and corrects the origin chain name display. Additionally, a changeset file was added documenting a patch fix for a typo in the payment confirmation widget. Changes
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (7)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
Playground
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/playground-web/src/app/connect/pay/embed/LeftSection.tsx (1)
108-108: Good change, but consider consistency across the file.Changing from
type="number"totype="text"is beneficial as chain IDs can be very large numbers that may not be handled well by number inputs. The parsing logic correctly handles the conversion.However, there's an inconsistency: the Chain ID input for the "checkout" mode (line 204) still uses
type="number". Consider updating it for consistency:<Input id="direct-payment-chain-id" - type="number" + type="text" placeholder="1 (Ethereum)"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/playground-web/src/app/connect/pay/embed/LeftSection.tsx(1 hunks)packages/thirdweb/src/react/web/ui/Bridge/payment-success/PaymentReceipt.tsx(4 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/thirdweb/src/react/web/ui/Bridge/payment-success/PaymentReceipt.tsx (1)
packages/thirdweb/src/react/web/ui/components/ChainName.tsx (1)
shorterChainName(32-40)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/thirdweb/src/react/web/ui/Bridge/payment-success/PaymentReceipt.tsx (4)
36-36: LGTM! Consistent interface extension.The addition of
destinationChainproperty maintains consistency with the existingoriginChainproperty and properly supports bridge transactions that span multiple chains.
106-106: LGTM! Property is properly populated.The
destinationChainproperty is correctly populated from the already-fetched metadata, ensuring the interface contract is fulfilled.
233-233: LGTM! Fixes incorrect chain reference.This change corrects a logical error where the "Origin Chain" label was displaying the destination chain name instead of the origin chain name. The fix properly uses
txInfo.originChain.namewhich aligns with the label.
289-295: LGTM! Critical syntax fix.The missing closing brace has been properly added, fixing the malformed onClick handler that would have caused a runtime syntax error.
size-limit report 📦
|
gregfromstl
force-pushed
the
greg/fix-ub-playground
branch
from
cb7e263 to
168de72
Compare
🦋 Changeset detectedLatest commit: ee29c07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gregfromstl
force-pushed
the
greg/fix-ub-playground
branch
from
168de72 to
ee29c07
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7371 +/- ##
==========================================
- Coverage 52.35% 52.35% -0.01%
==========================================
Files 939 939
Lines 63160 63161 +1
Branches 4214 4214
==========================================
Hits 33070 33070
- Misses 29983 29984 +1
Partials 107 107
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR focuses on fixing a typo in the payment confirmation widget and making adjustments to the payment handling in the application. It also updates the input type for a wallet chain ID and adds new properties related to the destination chain.
Detailed summary
typeof theInputwithid="fund-wallet-chain-id"fromnumbertotext.destinationChainproperty to the payment receipt's type definition.CompletedStepDetailCardto displayoriginChainname instead ofchainname.Summary by CodeRabbit
Bug Fixes
Refactor
New Features