Skip to content

[Nebula] Fix: Security headers for Mini App #7337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025

Conversation

PaoloRollo
Copy link
Contributor

@PaoloRollo PaoloRollo commented Jun 13, 2025

This PR fixes the security headers, correctly using frame-ancestors in the Content Security Policy header and not in X-Frame-Options.


PR-Codex overview

This PR updates the security configuration in apps/dashboard/next.config.ts by modifying the X-Frame-Options header to enhance protection against clickjacking and frame embedding.

Detailed summary

  • Added frame-ancestors 'self' https://farcaster.xyz https://*.farcaster.xyz; to the security headers.
  • Changed the X-Frame-Options value from frame-ancestors 'self' https://farcaster.xyz; default 'self' to SAMEORIGIN.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@PaoloRollo PaoloRollo requested review from a team as code owners June 13, 2025 19:32
@PaoloRollo PaoloRollo added merge-queue Adds the pull request to Graphite's merge queue. Dashboard Involves changes to the Dashboard. labels Jun 13, 2025
Copy link

vercel bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 7:39pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 7:39pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 7:39pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 7:39pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 7:39pm

Copy link

changeset-bot bot commented Jun 13, 2025

⚠️ No Changeset found

Latest commit: 1ffc06f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (2a175dc) to head (1ffc06f).
Report is 1 commits behind head on changeset-release/main.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           changeset-release/main    #7337   +/-   ##
=======================================================
  Coverage                   55.58%   55.58%           
=======================================================
  Files                         909      909           
  Lines                       58683    58683           
  Branches                     4160     4160           
=======================================================
  Hits                        32617    32617           
  Misses                      25959    25959           
  Partials                      107      107           
Flag Coverage Δ
packages 55.58% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.44 KB (0%) 1.3 s (0%) 527 ms (+29.59% 🔺) 1.8 s
thirdweb (cjs) 350.62 KB (0%) 7.1 s (0%) 3.2 s (+2.04% 🔺) 10.2 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 108 ms (+375.78% 🔺) 222 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 54 ms (+432.02% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 149 ms (+122.72% 🔺) 540 ms

@PaoloRollo PaoloRollo merged commit ab0f358 into changeset-release/main Jun 13, 2025
23 checks passed
@PaoloRollo PaoloRollo deleted the pr/fix-headers-miniapp branch June 13, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants