Skip to content

[Nebula] Feature: Farcaster Mini App #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 13, 2025
Merged

Conversation

PaoloRollo
Copy link
Contributor

@PaoloRollo PaoloRollo commented Jun 12, 2025

This PR allows the Nebula website to become a Farcaster Mini App.

Some important changes

  • I've changed in the next.config.ts file the security header X-Frame-Options to allow as frame-ancestors only self and farcaster.xyz to allow the Mini App to be opened from browser, since the browser version of Farcaster opens the apps using iframes
  • I've moved all the .well-known files of the dashboard under NextJS API routes in order to dynamically generate a farcaster.json based on the environment file

There are 4 new environment variables that need to be added:

NEXT_PUBLIC_APP_URL= # this is the app url, for prod is https://nebula.thirdweb.com
NEXT_PUBLIC_FARCASTER_HEADER= # farcaster manifest account association header generated on farcaster.xyz
NEXT_PUBLIC_FARCASTER_PAYLOAD= # farcaster manifest account association payload generated on farcaster.xyz
NEXT_PUBLIC_FARCASTER_SIGNATURE = # farcaster manifest account association signature generated on farcaster.xyz

How to test it

In order to test the Mini App, you need to have ngrok installed and you need to point it at http://nebula---localhost:3000 (ngrok won't work on local subdomains). Then, you need to set the NEXT_PUBLIC_APP_URL variable to your ngrok url, open the Mini App on Farcaster DevTools and generate the account association header, payload and signature. Get those values, and populate the missing env variables.

When this is all done, you can test your mini app both on browser and on your phone.


PR-Codex overview

This PR focuses on enhancing the Nebula application with new assets, improved configuration, and additional features for frame integration, including new SVG graphics and adjustments to environment variables.

Detailed summary

  • Updated next.config.ts to allow farcaster.xyz as a frame ancestor.
  • Added new dependencies: @farcaster/frame-core and @farcaster/frame-sdk.
  • Introduced multiple SVG assets for branding and UI.
  • Added new environment variables for Farcaster integration.
  • Implemented new API routes for asset links and app association.
  • Enhanced NebulaProviders with MiniAppProvider.
  • Updated metadata generation in layout.tsx.
  • Added error handling in frame context management.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@PaoloRollo PaoloRollo requested review from a team as code owners June 12, 2025 07:50
Copy link

linear bot commented Jun 12, 2025

Copy link

changeset-bot bot commented Jun 12, 2025

⚠️ No Changeset found

Latest commit: be35ac8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2025 6:16pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 13, 2025 6:16pm
login ⬜️ Skipped (Inspect) Jun 13, 2025 6:16pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 13, 2025 6:16pm
wallet-ui ⬜️ Skipped (Inspect) Jun 13, 2025 6:16pm

Copy link
Contributor

coderabbitai bot commented Jun 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 12, 2025
Copy link

socket-security bot commented Jun 12, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​farcaster/​frame-core@​0.1.109710075100100
Added@​farcaster/​frame-sdk@​0.0.609410078100100

View full report

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (5f57300) to head (be35ac8).
Report is 5 commits behind head on changeset-release/main.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           changeset-release/main    #7330   +/-   ##
=======================================================
  Coverage                   55.57%   55.58%           
=======================================================
  Files                         909      909           
  Lines                       58675    58683    +8     
  Branches                     4161     4160    -1     
=======================================================
+ Hits                        32609    32617    +8     
  Misses                      25959    25959           
  Partials                      107      107           
Flag Coverage Δ
packages 55.58% <ø> (+<0.01%) ⬆️

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 12, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.44 KB (0%) 1.3 s (0%) 575 ms (+56.71% 🔺) 1.9 s
thirdweb (cjs) 350.62 KB (0%) 7.1 s (0%) 2.8 s (+0.98% 🔺) 9.8 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 153 ms (+388.63% 🔺) 266 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 55 ms (+589.1% 🔺) 66 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 247 ms (+362.51% 🔺) 639 ms

@vercel vercel bot temporarily deployed to Preview – login June 12, 2025 09:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 12, 2025 09:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 12, 2025 09:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 12, 2025 09:07 Inactive
@joaquim-verges joaquim-verges force-pushed the changeset-release/main branch from 9d0bf9b to acb003f Compare June 12, 2025 21:02
@joaquim-verges joaquim-verges force-pushed the changeset-release/main branch from acb003f to 34d2345 Compare June 13, 2025 14:00
@vercel vercel bot temporarily deployed to Preview – login June 13, 2025 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 13, 2025 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 13, 2025 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 13, 2025 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 13, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 13, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 13, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 13, 2025 18:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 13, 2025 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 13, 2025 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 13, 2025 18:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 13, 2025 18:01 Inactive
@MananTank MananTank added the merge-queue Adds the pull request to Graphite's merge queue. label Jun 13, 2025
@PaoloRollo PaoloRollo merged commit 2a175dc into changeset-release/main Jun 13, 2025
22 checks passed
@PaoloRollo PaoloRollo deleted the pr/neb-251 branch June 13, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants