-
Notifications
You must be signed in to change notification settings - Fork 554
[Dashboard] Update URL rewrites for grants and superchain pages #7320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Update URL rewrites for grants and superchain pages #7320
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughThe rewrite paths in the grants section of the dashboard's framer-rewrites configuration were updated by splitting the original "/grant/superchain" route into two separate routes: "/grants" and "/superchain". Additionally, a URL in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DashboardRouter
User->>DashboardRouter: Request "/grants"
DashboardRouter-->>User: Route to grants page
User->>DashboardRouter: Request "/superchain"
DashboardRouter-->>User: Route to superchain page
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/dashboard/framer-rewrites.js
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7320 +/- ##
==========================================
- Coverage 55.57% 55.57% -0.01%
==========================================
Files 909 909
Lines 58673 58675 +2
Branches 4158 4157 -1
==========================================
+ Hits 32607 32608 +1
- Misses 25959 25960 +1
Partials 107 107
🚀 New features to boost your workflow:
|
size-limit report 📦
|
bd6fb3f
to
2bb0d4c
Compare
2bb0d4c
to
85dc71f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ BugBot reviewed your changes and found no bugs!
Was this report helpful? Give feedback by reacting with 👍 or 👎
TL;DR
Updated URL routing for grants section in the dashboard app.
What changed?
/grant/superchain
route/grants
- for the general grants page/superchain
- for the superchain-specific contentHow to test?
/grants
and verify it loads the grants page correctly/superchain
and verify it loads the superchain page correctly/grant/superchain
route no longer works or redirects appropriatelyWhy make this change?
This change improves URL structure by separating the grants and superchain content into their own distinct routes, making the navigation more intuitive and allowing each section to have its own dedicated URL path.
Summary by CodeRabbit
PR-Codex overview
This PR focuses on updating references from
/grant/superchain
to/superchain
across multiple files, improving clarity and consistency in the application.Detailed summary
apps/dashboard/framer-rewrites.js
, changed/grant/superchain
to/grants
and added/superchain
.apps/dashboard/redirects.js
, added a redirect from/grant/superchain
to/superchain
.apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/connect/account-abstraction/AccountAbstractionPage.tsx
, updated thehref
fromhttps://thirdweb.com/grant/superchain
tohttps://thirdweb.com/superchain
.apps/portal/src/app/account/billing/credits/page.mdx
, updated the text to reflect the new link tohttps://thirdweb.com/superchain
.