Skip to content

[Dashboard] Update URL rewrites for grants and superchain pages #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 11, 2025

TL;DR

Updated URL routing for grants section in the dashboard app.

What changed?

  • Removed the combined /grant/superchain route
  • Added two separate routes:
    • /grants - for the general grants page
    • /superchain - for the superchain-specific content

How to test?

  1. Navigate to /grants and verify it loads the grants page correctly
  2. Navigate to /superchain and verify it loads the superchain page correctly
  3. Verify that the old /grant/superchain route no longer works or redirects appropriately

Why make this change?

This change improves URL structure by separating the grants and superchain content into their own distinct routes, making the navigation more intuitive and allowing each section to have its own dedicated URL path.

Summary by CodeRabbit

  • Refactor
    • Updated grants section routes to split "/grant/superchain" into separate "/grants" and "/superchain" paths for improved navigation.
  • Bug Fixes
    • Corrected a link in the Gas Credit Alert to point directly to the updated superchain page.
    • Added a redirect from "/grant/superchain" to "/superchain" to ensure seamless navigation.
  • Documentation
    • Updated links in billing credits and informational pages to reflect the new superchain URL.

PR-Codex overview

This PR focuses on updating references from /grant/superchain to /superchain across multiple files, improving clarity and consistency in the application.

Detailed summary

  • In apps/dashboard/framer-rewrites.js, changed /grant/superchain to /grants and added /superchain.
  • In apps/dashboard/redirects.js, added a redirect from /grant/superchain to /superchain.
  • In apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/connect/account-abstraction/AccountAbstractionPage.tsx, updated the href from https://thirdweb.com/grant/superchain to https://thirdweb.com/superchain.
  • In apps/portal/src/app/account/billing/credits/page.mdx, updated the text to reflect the new link to https://thirdweb.com/superchain.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 1:05am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 1:05am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Jun 11, 2025 1:05am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 11, 2025 1:05am
wallet-ui ⬜️ Skipped (Inspect) Jun 11, 2025 1:05am

@vercel vercel bot temporarily deployed to Preview – wallet-ui June 11, 2025 00:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 11, 2025 00:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 11, 2025 00:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 11, 2025 00:21 Inactive
Copy link

changeset-bot bot commented Jun 11, 2025

⚠️ No Changeset found

Latest commit: 85dc71f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 11, 2025

Walkthrough

The rewrite paths in the grants section of the dashboard's framer-rewrites configuration were updated by splitting the original "/grant/superchain" route into two separate routes: "/grants" and "/superchain". Additionally, a URL in the GasCreditAlert component and a link in the billing credits page were updated from "https://thirdweb.com/grant/superchain" to "https://thirdweb.com/superchain". A new redirect rule was also added to redirect /grant/superchain to /superchain.

Changes

File Change Summary
apps/dashboard/framer-rewrites.js Split "/grant/superchain" route into "/grants" and "/superchain" in rewrite paths array
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/connect/account-abstraction/AccountAbstractionPage.tsx
apps/portal/src/app/account/billing/credits/page.mdx
Updated URLs from "https://thirdweb.com/grant/superchain" to "https://thirdweb.com/superchain"
apps/dashboard/redirects.js Added redirect rule from "/grant/superchain" to "/superchain" with non-permanent redirect status

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DashboardRouter

    User->>DashboardRouter: Request "/grants"
    DashboardRouter-->>User: Route to grants page

    User->>DashboardRouter: Request "/superchain"
    DashboardRouter-->>User: Route to superchain page
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2bb0d4c and 85dc71f.

📒 Files selected for processing (4)
  • apps/dashboard/framer-rewrites.js (1 hunks)
  • apps/dashboard/redirects.js (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/connect/account-abstraction/AccountAbstractionPage.tsx (1 hunks)
  • apps/portal/src/app/account/billing/credits/page.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • apps/portal/src/app/account/billing/credits/page.mdx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/connect/account-abstraction/AccountAbstractionPage.tsx
  • apps/dashboard/redirects.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/framer-rewrites.js
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 11, 2025
@jnsdls jnsdls marked this pull request as ready for review June 11, 2025 00:21
@jnsdls jnsdls requested review from a team as code owners June 11, 2025 00:21
Copy link
Member Author

jnsdls commented Jun 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99d6b3b and bd6fb3f.

📒 Files selected for processing (1)
  • apps/dashboard/framer-rewrites.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (81c66f4) to head (85dc71f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7320      +/-   ##
==========================================
- Coverage   55.57%   55.57%   -0.01%     
==========================================
  Files         909      909              
  Lines       58673    58675       +2     
  Branches     4158     4157       -1     
==========================================
+ Hits        32607    32608       +1     
- Misses      25959    25960       +1     
  Partials      107      107              
Flag Coverage Δ
packages 55.57% <ø> (-0.01%) ⬇️

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 11, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.57 KB (0%) 1.3 s (0%) 439 ms (+59.12% 🔺) 1.7 s
thirdweb (cjs) 345.55 KB (0%) 7 s (0%) 2.3 s (+6.56% 🔺) 9.2 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 62 ms (+209.46% 🔺) 176 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 46 ms (+634.59% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.56 KB (0%) 392 ms (0%) 208 ms (+288.5% 🔺) 600 ms

@jnsdls jnsdls force-pushed the _Dashboard_Update_URL_rewrites_for_grants_and_superchain_pages branch from bd6fb3f to 2bb0d4c Compare June 11, 2025 00:40
@vercel vercel bot temporarily deployed to Preview – login June 11, 2025 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 11, 2025 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 11, 2025 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 11, 2025 00:40 Inactive
cursor[bot]

This comment was marked as outdated.

@jnsdls jnsdls force-pushed the _Dashboard_Update_URL_rewrites_for_grants_and_superchain_pages branch from 2bb0d4c to 85dc71f Compare June 11, 2025 00:57
@vercel vercel bot temporarily deployed to Preview – login June 11, 2025 00:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 11, 2025 00:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 11, 2025 00:57 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jun 11, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


Was this report helpful? Give feedback by reacting with 👍 or 👎

@jnsdls jnsdls merged commit 950bbae into main Jun 11, 2025
25 checks passed
@jnsdls jnsdls deleted the _Dashboard_Update_URL_rewrites_for_grants_and_superchain_pages branch June 11, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant