updated old support links to portal #7286
Conversation
GiselleNessi
requested review from
jnsdls,
joaquim-verges and
a team
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe support page was refactored to use React icon components instead of static images for product icons, updated product categories and descriptions, and removed help article lists in favor of concise descriptions. The page heading and button text were also updated, and two new products were added to the product list. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SupportPage
participant IconComponent
User->>SupportPage: Visit Support Page
SupportPage->>IconComponent: Render product icon (as React component)
SupportPage-->>User: Display product list with icons and descriptions
User->>SupportPage: Click "View" button
SupportPage-->>User: Redirect to product's viewAllUrl
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7286 +/- ##
=======================================
Coverage 55.58% 55.58%
=======================================
Files 909 909
Lines 58670 58670
Branches 4158 4158
=======================================
Hits 32609 32609
Misses 25954 25954
Partials 107 107
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/dashboard/src/app/(app)/(dashboard)/support/page.tsx (1)
25-87: 💡 Verification agent🧩 Analysis chain
Verify the updated product data aligns with portal documentation.
The HELP_PRODUCTS data has been significantly restructured with new products (Universal Bridge, Insight, Nebula) and updated URLs pointing to portal.thirdweb.com. This aligns well with the PR objective.
Run the following script to verify that the portal URLs are accessible:
🏁 Script executed:
#!/bin/bash # Description: Verify that all portal URLs in the updated product data are accessible urls=( "https://playground.thirdweb.com/connect/sign-in/button?tab=code" "https://portal.thirdweb.com/connect" "https://portal.thirdweb.com/pay" "https://portal.thirdweb.com/engine/v3" "https://portal.thirdweb.com/insight" "https://portal.thirdweb.com/nebula" ) for url in "${urls[@]}"; do echo "Checking: $url" if curl -s --head "$url" | head -n 1 | grep -q "200 OK"; then echo "✓ $url is accessible" else echo "✗ $url returned an error" fi doneLength of output: 2380
Validate portal URLs accessibility
Our accessibility check shows that none of the updated
viewAllUrlendpoints are returning a200 OK. Please verify that these links are correct and update them accordingly:
- https://playground.thirdweb.com/connect/sign-in/button?tab=code
- https://portal.thirdweb.com/connect
- https://portal.thirdweb.com/pay
- https://portal.thirdweb.com/engine/v3
- https://portal.thirdweb.com/insight
- https://portal.thirdweb.com/nebula
Once the URLs are corrected, rerun the verification script to ensure they’re all accessible.
🧹 Nitpick comments (1)
apps/dashboard/src/app/(app)/(dashboard)/support/page.tsx (1)
7-12: Consider using absolute imports for better maintainability.The deep relative path imports (
../../../../../../portal/src/icons/products/) are fragile and difficult to maintain. Consider setting up a path alias or using absolute imports from a centralized icon library.-import { BridgeIcon } from "../../../../../../portal/src/icons/products/BridgeIcon"; -import { ConnectIcon } from "../../../../../../portal/src/icons/products/ConnectIcon"; -import { EngineIcon } from "../../../../../../portal/src/icons/products/EngineIcon"; -import { InsightIcon } from "../../../../../../portal/src/icons/products/InsightIcon"; -import { NebulaIcon } from "../../../../../../portal/src/icons/products/NebulaIcon"; -import { PlaygroundIcon } from "../../../../../../portal/src/icons/products/PlaygroundIcon"; +import { + BridgeIcon, + ConnectIcon, + EngineIcon, + InsightIcon, + NebulaIcon, + PlaygroundIcon +} from "@/icons/products";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.vscode/settings.json(1 hunks)apps/dashboard/src/app/(app)/(dashboard)/support/page.tsx(5 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/dashboard/src/app/(app)/(dashboard)/support/page.tsx (1)
apps/dashboard/src/app/nebula-app/(app)/icons/NebulaIcon.tsx (1)
NebulaIcon(1-24)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
.vscode/settings.json (1)
20-20: Clarify the relationship to PR objectives.This formatter change from
biomejs.biometorvest.vs-code-prettier-eslintfor TypeScript React files appears unrelated to the stated PR objective of updating support links to portal. Please confirm if this change is intentional and necessary for this PR.apps/dashboard/src/app/(app)/(dashboard)/support/page.tsx (4)
150-150: Good update to the section heading.The change from "Knowledge base" to "Learning Resources" better reflects the updated content and aligns with the modernized support experience.
166-166: Good simplification of button text.The change from "View All" to "View" is more concise while maintaining clarity.
176-178: Confirm the removal of article interactivity is intentional.The help articles are now rendered as plain
<span>elements instead of clickable links. This removes user interaction but may be intentional if the articles are purely descriptive. Please confirm this change aligns with the intended user experience.
156-156:✅ Verification successful
Verify icon component props compatibility.
The change from using Next.js Image components to React icon components looks good, but ensure that all imported icon components accept the
classNameprop as expected.
🏁 Script executed:
#!/bin/bash # Description: Verify that all icon components accept className prop icon_files=( "BridgeIcon" "ConnectIcon" "EngineIcon" "InsightIcon" "NebulaIcon" "PlaygroundIcon" ) for icon in "${icon_files[@]}"; do echo "Checking $icon component:" rg -A 10 "export.*function.*$icon" | head -15 echo "---" doneLength of output: 7009
🏁 Script executed:
#!/bin/bash # Verify that EngineIcon spreads props to its <svg> element rg -n "export function EngineIcon" -A20 apps/portal/src/icons/products/EngineIcon.tsxLength of output: 809
All product icon components support the
classNamepropI’ve verified that each icon (BridgeIcon, ConnectIcon, EngineIcon, InsightIcon, NebulaIcon, PlaygroundIcon) either explicitly accepts
{ className?: string }or spreadsprops(includingclassName) onto the<svg>. No changes are needed.
size-limit report 📦
|
| </li> | ||
| ))} | ||
| </ul> | ||
| <CardContent key={product.description}> |
There was a problem hiding this comment.
don't need key here since this is not rendered in an array
GiselleNessi
added
the
merge-queue
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the `SupportPage` component in the `page.tsx` file by adding new features, modifying existing sections, and improving the overall structure and content of the help products.
### Detailed summary
- Added new icons: `HomeIcon`, `WalletIcon`, `EngineIcon`, `InsightIcon`, `PayIcon`, and `NebulaIcon`.
- Introduced a new help product: "Playground".
- Replaced "Connect" product icon and updated its description.
- Changed "Contracts" to "Universal Bridge" with a new icon and description.
- Updated "Engine" product with a new icon and description.
- Replaced "Account" with "Insight" and updated its details.
- Replaced "Misc" with "Nebula" and updated its details.
- Changed section title from "Knowledge base" to "Learning Resources".
- Modified product icon rendering from image to component usage.
- Updated button text from "View All" to "View".
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **New Features**
- Introduced new products "Playground" and "Nebula" to the support page.
- **Improvements**
- Updated product categories, icons, and descriptions for a clearer overview.
- Replaced static images with modern icon components for improved visual consistency.
- Changed page heading to "Learning Resources."
- Simplified layout by replacing help article lists with concise product descriptions.
- Shortened the "View All" button text to "View."
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
gi/update-support-links
branch
from
ef74a38 to
c77b4d8
Compare
graphite-app
bot
removed
the
merge-queue
PR-Codex overview
This PR focuses on updating the
SupportPagein thedashboardapplication by modifying theHELP_PRODUCTSarray, enhancing the user interface, and improving the organization of the support resources.Detailed summary
HomeIcon,WalletIcon,EngineIcon,InsightIcon,PayIcon, andNebulaIcon.Connect,Contracts,Engine, andAccountentries with new details.Summary by CodeRabbit