Skip to content

[Dashboard] Feature: Adds PostHog tracking to bridge page #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented May 30, 2025


PR-Codex overview

This PR introduces the integration of the PHProvider and PostHogPageView components into the Providers component of two files, enhancing analytics tracking within the application.

Detailed summary

  • Added import statements for PHProvider and PostHogPageView in both Providers.client.tsx files.
  • Wrapped children and Toaster components with PHProvider.
  • Included PostHogPageView component inside PHProvider.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Introduced enhanced analytics and page view tracking across dashboard and payment pages.

…onent

- Added `PHProvider` and `PostHogPageView` to the `Providers` component for improved user behavior tracking.
- Wrapped children and `Toaster` component within `PHProvider` to ensure analytics are captured across the application.
@gregfromstl gregfromstl requested review from a team as code owners May 30, 2025 20:01
Copy link

vercel bot commented May 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 8:14pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 30, 2025 8:14pm
login ⬜️ Skipped (Inspect) May 30, 2025 8:14pm
thirdweb_playground ⬜️ Skipped (Inspect) May 30, 2025 8:14pm
wallet-ui ⬜️ Skipped (Inspect) May 30, 2025 8:14pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 30, 2025 20:01 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 30, 2025 20:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 30, 2025 20:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 30, 2025 20:01 Inactive
Copy link

changeset-bot bot commented May 30, 2025

⚠️ No Changeset found

Latest commit: fff8016

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented May 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

coderabbitai bot commented May 30, 2025

Walkthrough

The Providers components in both the client and pay sections of the dashboard app were updated to include PostHog analytics. This was achieved by wrapping their children and the Toaster component within a new PHProvider and adding a PostHogPageView component, integrating analytics context and page view tracking into the provider hierarchy.

Changes

File(s) Change Summary
.../dashboard/src/app/bridge/components/client/Providers.client.tsx Wrapped children and Toaster in PHProvider; added PostHogPageView for analytics context and tracking
.../dashboard/src/app/pay/components/client/Providers.client.tsx Same as above: integrated PHProvider and PostHogPageView into Providers component

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant Providers
    participant PHProvider
    participant PostHogPageView
    participant Toaster
    participant Children

    App ->> Providers: Render
    Providers ->> PHProvider: Wrap children
    PHProvider ->> PostHogPageView: Render for analytics tracking
    PHProvider ->> Children: Render original children
    PHProvider ->> Toaster: Render Toaster component
Loading

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ae54dd and fff8016.

📒 Files selected for processing (2)
  • apps/dashboard/src/app/bridge/components/client/Providers.client.tsx (2 hunks)
  • apps/dashboard/src/app/pay/components/client/Providers.client.tsx (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
apps/dashboard/src/app/pay/components/client/Providers.client.tsx (1)
apps/dashboard/src/lib/posthog/Posthog.tsx (1)
  • PHProvider (10-28)
apps/dashboard/src/app/bridge/components/client/Providers.client.tsx (1)
apps/dashboard/src/lib/posthog/Posthog.tsx (1)
  • PHProvider (10-28)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: Build Packages
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
apps/dashboard/src/app/bridge/components/client/Providers.client.tsx (2)

5-6: LGTM: Clean PostHog integration imports

The import paths for PostHog components are correct and follow the established project structure.


17-21: LGTM: Well-structured provider hierarchy

The PostHog integration is properly implemented:

  • PHProvider is correctly nested within the existing provider hierarchy
  • PostHogPageView component is appropriately placed as the first child
  • Existing children and Toaster are preserved within the PostHog context
  • The provider order ensures PostHog analytics context is available to all child components

Based on the relevant code snippet, the PHProvider includes proper conditional initialization for production environments only, which is a good security practice.

apps/dashboard/src/app/pay/components/client/Providers.client.tsx (2)

4-5: LGTM: Consistent PostHog imports

The import statements match the pattern used in the bridge component, ensuring consistency across the dashboard sections.


10-14: LGTM: Consistent PostHog integration implementation

The PostHog integration follows the exact same pattern as the bridge component:

  • PHProvider properly wraps all child components
  • PostHogPageView is correctly positioned for page view tracking
  • Existing functionality is preserved
  • Provider hierarchy maintains proper context flow

This consistency ensures uniform analytics behavior across both the bridge and pay sections of the dashboard.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 30, 2025
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.62%. Comparing base (6ae54dd) to head (fff8016).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7232   +/-   ##
=======================================
  Coverage   55.62%   55.62%           
=======================================
  Files         908      908           
  Lines       58575    58575           
  Branches     4132     4132           
=======================================
  Hits        32582    32582           
  Misses      25886    25886           
  Partials      107      107           
Flag Coverage Δ
packages 55.62% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.14 KB (0%) 1.3 s (0%) 290 ms (+133.5% 🔺) 1.6 s
thirdweb (cjs) 344.83 KB (0%) 6.9 s (0%) 947 ms (+3.59% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 65 ms (+893.37% 🔺) 179 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 19 ms (+804.01% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 19.52 KB (0%) 391 ms (0%) 116 ms (+514.05% 🔺) 507 ms

@gregfromstl gregfromstl merged commit 196cb54 into main May 30, 2025
25 checks passed
@gregfromstl gregfromstl deleted the greg/adds-posthog-tracker branch May 30, 2025 20:23
This was referenced Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant