Skip to content

refactor: improve aggregate parameter input with MultiSelect #7169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

catalyst17
Copy link
Contributor

@catalyst17 catalyst17 commented May 27, 2025

PR-Codex overview

This PR focuses on improving the formatting of a string by modifying how it is split into an array and then processed to remove leading and trailing spaces.

Detailed summary

  • Changed the order of operations for processing value.
  • Modified the split method to use a single line instead of a multi-line format.
  • Removed the trailing comma in the filter method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 9:36am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 27, 2025 9:36am
login ⬜️ Skipped (Inspect) May 27, 2025 9:36am
thirdweb-www ⬜️ Skipped (Inspect) May 27, 2025 9:36am
wallet-ui ⬜️ Skipped (Inspect) May 27, 2025 9:36am

@vercel vercel bot temporarily deployed to Preview – login May 27, 2025 09:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 27, 2025 09:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 09:01 Inactive
Copy link

changeset-bot bot commented May 27, 2025

⚠️ No Changeset found

Latest commit: b1d6b81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 09:01 Inactive
Copy link
Contributor

coderabbitai bot commented May 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label May 27, 2025
Copy link
Contributor Author

catalyst17 commented May 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (03342b3) to head (b1d6b81).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           graphite-base/7169    #7169   +/-   ##
===================================================
  Coverage               55.67%   55.67%           
===================================================
  Files                     904      904           
  Lines                   58391    58391           
  Branches                 4119     4119           
===================================================
  Hits                    32510    32510           
  Misses                  25775    25775           
  Partials                  106      106           
Flag Coverage Δ
packages 55.67% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 61.75 KB (0%) 1.3 s (0%) 248 ms (+222.79% 🔺) 1.5 s
thirdweb (cjs) 344.4 KB (0%) 6.9 s (0%) 632 ms (+5.66% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 90 ms (+1305.99% 🔺) 204 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 27 ms (+1840.1% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 19.54 KB (0%) 391 ms (0%) 78 ms (+509.81% 🔺) 469 ms

@catalyst17 catalyst17 force-pushed the refactor_improve_aggregate_parameter_input_with_MultiSelect branch from 1ec21f8 to 6328916 Compare May 27, 2025 09:09
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 09:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 09:10 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 27, 2025 09:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 27, 2025 09:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 27, 2025 09:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 09:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 09:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 27, 2025 09:21 Inactive
@catalyst17 catalyst17 changed the base branch from feat_enhance_aggregate_parameter_input_with_multi-select_presets to graphite-base/7169 May 27, 2025 09:23
@catalyst17 catalyst17 force-pushed the refactor_improve_aggregate_parameter_input_with_MultiSelect branch from d6cb024 to 6b66183 Compare May 27, 2025 09:32
@catalyst17 catalyst17 force-pushed the graphite-base/7169 branch from a82e7b1 to 03342b3 Compare May 27, 2025 09:32
@catalyst17 catalyst17 changed the base branch from graphite-base/7169 to feat_enhance_aggregate_parameter_input_with_multi-select_presets May 27, 2025 09:32
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 09:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 09:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 27, 2025 09:32 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 27, 2025 09:32 Inactive
@catalyst17 catalyst17 force-pushed the refactor_improve_aggregate_parameter_input_with_MultiSelect branch from 6b66183 to b1d6b81 Compare May 27, 2025 09:35
@vercel vercel bot temporarily deployed to Preview – login May 27, 2025 09:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 27, 2025 09:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 27, 2025 09:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 27, 2025 09:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 27, 2025 09:36 Inactive
@catalyst17 catalyst17 changed the base branch from feat_enhance_aggregate_parameter_input_with_multi-select_presets to graphite-base/7169 May 27, 2025 09:36
@catalyst17 catalyst17 closed this May 27, 2025
@catalyst17 catalyst17 deleted the refactor_improve_aggregate_parameter_input_with_MultiSelect branch May 27, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant