Skip to content

[Engine] Update OpenAPI spec and configuration #7050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 14, 2025


PR-Codex overview

This PR focuses on updating the base URL and input configurations for the @thirdweb-dev/engine, transitioning from a localhost environment to a production environment. It also modifies function calls and updates types to include clientId.

Detailed summary

  • Updated baseUrl in client.gen.ts and openapi-ts.config.ts to production URL.
  • Changed configure function's clientId to secretKey in README.md.
  • Replaced getV1Events with writeContract in example usage.
  • Added clientId to multiple type definitions in types.gen.ts.
  • Updated ClientOptions to reflect the new baseUrl.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 10:50pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 10:50pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 10:50pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 10:50pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 10:50pm

Copy link

changeset-bot bot commented May 14, 2025

🦋 Changeset detected

Latest commit: 205d885

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@thirdweb-dev/engine Patch
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review May 14, 2025 22:32
Copy link
Member Author

joaquim-verges commented May 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented May 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 248 ms (+136.7% 🔺) 1.4 s
thirdweb (cjs) 193.71 KB (0%) 3.9 s (0%) 498 ms (+18.9% 🔺) 4.4 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 88 ms (+754.93% 🔺) 202 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 43 ms (+1247.95% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 74 ms (+318.17% 🔺) 465 ms

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Signed-off-by: Joaquim Verges <[email protected]>
@joaquim-verges joaquim-verges merged commit ae2ff74 into main May 14, 2025
19 of 21 checks passed
@joaquim-verges joaquim-verges deleted the _Engine_Update_OpenAPI_spec_and_configuration branch May 14, 2025 22:43
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (9f1ca54) to head (205d885).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7050      +/-   ##
==========================================
- Coverage   55.51%   55.50%   -0.01%     
==========================================
  Files         909      909              
  Lines       58402    58402              
  Branches     4071     4070       -1     
==========================================
- Hits        32419    32415       -4     
- Misses      25878    25882       +4     
  Partials      105      105              
Flag Coverage Δ
packages 55.50% <ø> (-0.01%) ⬇️

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant