Skip to content

[SDK] Add erc1155.transferBatch #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jan 25, 2024

Problem solved

Exposes erc1155.transferBatch API

Changes made

  • Added transferBatch method to erc1155 standard
  • Added test

How to test

  • custom.test.ts

@0xFirekeeper 0xFirekeeper requested a review from a team January 25, 2024 21:42
Copy link

changeset-bot bot commented Jan 25, 2024

🦋 Changeset detected

Latest commit: 80c5e08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@0xFirekeeper 0xFirekeeper changed the title Firekeeper/1155 transfer batch [SDK] Add erc1155.transferBatch Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1a5d41c) 67.51% compared to head (80c5e08) 67.56%.
Report is 3 commits behind head on main.

Files Patch % Lines
...core/classes/internal/erc1155/erc-1155-standard.ts 33.33% 2 Missing ⚠️
packages/sdk/src/evm/core/classes/erc-1155.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2220      +/-   ##
==========================================
+ Coverage   67.51%   67.56%   +0.04%     
==========================================
  Files         291      291              
  Lines       11016    11042      +26     
  Branches     1513     1519       +6     
==========================================
+ Hits         7438     7461      +23     
- Misses       2952     2954       +2     
- Partials      626      627       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 3d63a2c Jan 26, 2024
@0xFirekeeper 0xFirekeeper deleted the firekeeper/1155-transferBatch branch January 26, 2024 00:06
@jnsdls jnsdls mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants