Skip to content

[SDK] switch to LRU caches #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024
Merged

[SDK] switch to LRU caches #2215

merged 1 commit into from
Jan 25, 2024

Conversation

joaquim-verges
Copy link
Member

Problem solved

bounded instead of unbounded caches for metadata + contract instances

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@joaquim-verges joaquim-verges requested a review from a team January 25, 2024 05:28
Copy link

changeset-bot bot commented Jan 25, 2024

🦋 Changeset detected

Latest commit: 9a08df7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges
Copy link
Member Author

/release-pr

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a5d41c) 67.51% compared to head (9a08df7) 67.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2215      +/-   ##
==========================================
+ Coverage   67.51%   67.57%   +0.05%     
==========================================
  Files         291      291              
  Lines       11016    11035      +19     
  Branches     1513     1516       +3     
==========================================
+ Hits         7438     7457      +19     
  Misses       2952     2952              
  Partials      626      626              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquim-verges joaquim-verges added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit b34737d Jan 25, 2024
@joaquim-verges joaquim-verges deleted the joaquim/lru branch January 25, 2024 20:27
@jnsdls jnsdls mentioned this pull request Jan 25, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* Fix deprecation alert

* Never showing it when it shouldn't be there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant