Skip to content

[RN] Update coinbase wallet SDK to fix scheme bug #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 19, 2023
Merged

[RN] Update coinbase wallet SDK to fix scheme bug #2099

merged 3 commits into from
Dec 19, 2023

Conversation

iketw
Copy link
Contributor

@iketw iketw commented Dec 19, 2023

Problem solved

There's a listener that handles CoinbaseWallet's deeplinks. This listener calls a static function of the Coinbase wallet SDK called handleResponse to manage the deeplinks.

The handleResponse static function had a bug when checking if the Coinbase SDK was already instantiated (Fix here. Since we only initialize the CoinbaseWallet once a user connects to it, opening the app from the deeplink was crashing if the Coinbase wallet was not connected.

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

We alerted Coinbase, they applied the fix and we updated their package

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@iketw iketw requested a review from a team December 19, 2023 00:04
Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 2644666

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@thirdweb-dev/react-native Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iketw
Copy link
Contributor Author

iketw commented Dec 19, 2023

/release-pr

@iketw iketw added this pull request to the merge queue Dec 19, 2023
Merged via the queue into main with commit 94a8f79 Dec 19, 2023
@iketw iketw deleted the ike/scheme branch December 19, 2023 00:34
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant