[RN] Update coinbase wallet SDK to fix scheme bug #2099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
There's a listener that handles CoinbaseWallet's deeplinks. This listener calls a static function of the Coinbase wallet SDK called
handleResponse
to manage the deeplinks.The
handleResponse
static function had a bug when checking if the Coinbase SDK was already instantiated (Fix here. Since we only initialize the CoinbaseWallet once a user connects to it, opening the app from the deeplink was crashing if the Coinbase wallet was not connected.Changes made
We alerted Coinbase, they applied the fix and we updated their package
How to test