feat: ethers skipFetchSetup support
#2085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4698681 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Awesome, @hsynlms Thank you very much for this! LGTM 🚀 We will merge this shortly |
Merged
4 tasks
jnsdls
pushed a commit
that referenced
this pull request
Jun 19, 2024
* Fix snowtrace sourcecode verify api * Update blockroute snowtrace API * Blockroute API compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
This fixes #2002
It may not be the clearest solution but the quick one. If the global environment variable
TW_SKIP_FETCH_SETUPis set, the Thirdweb SDK will assign the value of it to theskipFetchSetupoption. When ethers.js v6 support arrives, we need to revert this commit. This is also commented on the source as a todo.Changes made
How to test
TW_SKIP_FETCH_SETUPto true and the issue explained in the related issue number Error Encountered When Running Code withvite-node#2002 will be gone