Handle Facter errors as failures

Author: PaulSD

files/report.rb

@@ -121,6 +121,9 @@ def metrics_to_hash(report)
     end
     # fix for Puppet non-resource errors (i.e. failed catalog fetches before falling back to cache)
     report_status["failed"] += report.logs.find_all {|l| l.source =~ /Puppet$/ && l.level.to_s == 'err' }.count
+    unless SETTINGS[:report_ignore_facter_errors]
+      report_status["failed"] += report.logs.count {|l| l.source == 'Facter' && l.level.to_s == 'err' }
+    end
 
     return report_status
   end

manifests/init.pp

@@ -36,6 +36,8 @@
 #   The timeout to use on HTTP calls in the report processor
 # @param report_retry_limit
 #   The number of times to retry HTTP calls in the report processor
+# @param report_ignore_facter_errors
+#   Whether to exclude facter errors from report metrics
 # @param puppet_basedir
 #   The directory used to install the report processor to
 # @param use_client_tls_certs
@@ -54,6 +56,7 @@
   Boolean $reports = true,
   Integer[0] $reports_timeout = 60,
   Integer[0] $report_retry_limit = 1,
+  Boolean $report_ignore_facter_errors = false,
   Variant[Enum[''], Stdlib::Absolutepath] $ssl_ca = $puppetserver_foreman::params::client_ssl_ca,
   Variant[Enum[''], Stdlib::Absolutepath] $ssl_cert = $puppetserver_foreman::params::client_ssl_cert,
   Variant[Enum[''], Stdlib::Absolutepath] $ssl_key = $puppetserver_foreman::params::client_ssl_key,

spec/classes/init_spec.rb

@@ -129,6 +129,7 @@
             ':timeout: 60',
             ':report_timeout: 60',
             ':report_retry_limit: 1',
+            ':report_ignore_facter_errors: false',
             ':threads: null',
           ])
         end

templates/puppet.yaml.erb

@@ -12,4 +12,5 @@
 :timeout: <%= @enc_timeout %>
 :report_timeout: <%= @reports_timeout %>
 :report_retry_limit: <%= @report_retry_limit %>
+:report_ignore_facter_errors: "<%= @report_ignore_facter_errors %>"
 :threads: null