Skip to content

Add typescript definitions to DefinitelyTyped #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weyert opened this issue Aug 14, 2019 · 5 comments · Fixed by #87
Closed

Add typescript definitions to DefinitelyTyped #84

weyert opened this issue Aug 14, 2019 · 5 comments · Fixed by #87
Labels
enhancement New feature or request has PR There's an open PR to solve/close the issue released

Comments

@weyert
Copy link

weyert commented Aug 14, 2019

Let's add DefinitelyTyped type definitions for vue-testing-library
@weyert
Copy link
Author

weyert commented Aug 14, 2019

I will pick this up 💃

@afontcu
Copy link
Member

afontcu commented Aug 14, 2019

By all means! thanks 🤘🏼🙌🏼

@afontcu afontcu added the enhancement New feature or request label Aug 14, 2019
@afontcu
Copy link
Member

afontcu commented Aug 15, 2019 •
edited
Loading

For reference, looks like a PR is already opened:

DefinitelyTyped/DefinitelyTyped#37655

@afontcu afontcu added the has PR There's an open PR to solve/close the issue label Aug 18, 2019
@afontcu afontcu mentioned this issue Aug 18, 2019
Merged
@weyert
Copy link
Author

weyert commented Aug 18, 2019

Sweet :)

@afontcu
Copy link
Member

afontcu commented Aug 18, 2019

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request has PR There's an open PR to solve/close the issue released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Vue Testing Library types from DefinitelyTyped testing-library/vue-testing-library
2 participants
@weyert @afontcu