Skip to content

Update user event's delay option to say milliseconds instead of seconds #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

bsheps
Copy link
Contributor

@bsheps bsheps commented Oct 31, 2023

The delay value gets passed into setTimeout which takes a value in milliseconds (not seconds).

fixes #1335

@netlify
Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 7dfe932
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/65406e07e0961b0009546101
😎 Deploy Preview https://deploy-preview-1334--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatanBobi
Copy link
Member

Thanks!

@MatanBobi MatanBobi merged commit 4085adf into testing-library:main Oct 31, 2023
@MatanBobi
Copy link
Member

@all-contributors please add @bsheps for docs :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @bsheps! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User event's delay value is incorrect documented as seconds
3 participants