Skip to content

chore: issue templates #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexkrolick
Copy link
Collaborator

@alexkrolick alexkrolick commented May 4, 2018

What:

Adds the new GitHub templates

Why:

How:

Checklist:

  • Documentation
  • ~~~Tests~~~
  • Ready to be merged
  • Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just fantastic. Thank you!


-->

**Describe the feature you'd like**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be consistent with headings/comments here as we are in the bugs one. I think I prefer headings and comments over ** and non-comments. Also, make sure to add an extra line after these 👍

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 quick things, then feel free to merge 👍 Thanks!


-->

### Describe the feature you'd like:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a section after this one for "### Suggested implementation" with a comment that says it's helpful but optional?


-------------- 👆 Click "Preview"!

Issues on GitHub are intended to be related to problems with the library itself,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*and feature requests

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super duper! Thank you. This is very cool 👍

@kentcdodds kentcdodds merged commit 5356f20 into testing-library:master May 4, 2018
@alexkrolick alexkrolick deleted the chore/issue-templates branch May 4, 2018 03:04
@kentcdodds
Copy link
Member

🎉 This PR is included in version 2.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants