Skip to content

docs(contributors): add sompylasar #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sompylasar
Copy link
Contributor

@sompylasar sompylasar commented Mar 29, 2018

#3 👈

@sompylasar
Copy link
Contributor Author

@kentcdodds Please note that this PR removes @lgandecki 's "Documentation" contribution from the README because "doc" was missing from .all-contributorsrc. I think "doc" should be added, and README regenerated.

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #29   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          73     73           
  Branches       17     17           
=====================================
  Hits           73     73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0083286...4f83b8d. Read the comment docs.

@lgandecki
Copy link
Collaborator

Shoot somehow I managed to mess it up? :) I think you can fix it by yourself as well - if you run the all contribution script and put my github id and select doc. Wanna give it a try? We would prevent this changing back and forth

@sompylasar
Copy link
Contributor Author

Fixed 4f83b8d

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks!

@kentcdodds kentcdodds merged commit 66b5a2c into testing-library:master Mar 29, 2018
julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
* fix: use exact match for data-testid

[fixes testing-library#8]

* add tests for exact matches

* disallow substring match

* fix: heading level for getByTestId

* Add docs for ExactTextMatch

* Update README.md
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants