Skip to content

fix: pass arguments correctly #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

JoviDeCroock
Copy link
Member

Fixes #61

What:

We did not pass init correctly to domFireEvent, this looks at the signature of DomFireEvent and passes init.

CC @mikerob215

Checklist:

  • Documentation added
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@JoviDeCroock
Copy link
Member Author

Closing in favor of #63

@JoviDeCroock JoviDeCroock deleted the pass-arguments-correctly branch June 8, 2022 17:38
@vbabel
Copy link
Contributor

vbabel commented Jun 8, 2022

Sorry! Should have noted in that issue that I had a fix ready, just figured it be best to have the issue for record keeeping.

@JoviDeCroock
Copy link
Member Author

No worries, happy that you managed to fix it @vbabel and thanks for adding the tests, highly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fireEvent updates in 3.0.2 introduced a regression
2 participants