Skip to content

Conversation

benmonro
Copy link
Member

this PR prevents direct checks against attributes.

examples:

expect(element.checked).toBeTruthy()
expect(getByText('foo').checked).toBeFalsy()
expect(getByText('foo').checked).toBe(true)

expect(getByText('foo').checked).toBe(false)

expect(getByText('foo').checked).toBe(null)

expect(getByText('foox').checked).toEqual(undefined)
expect(element.checked).toBe(true)

@benmonro benmonro merged commit 87566a2 into master Nov 18, 2019
@benmonro benmonro deleted the feature/checked-direct branch November 18, 2019 15:59
@benmonro
Copy link
Member Author

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant