Skip to content

fix: update dom-accessibility-api #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marcosvega91
Copy link
Member

@marcosvega91 marcosvega91 commented Aug 20, 2020

fix #747

What: This PR will update dom-accessibility-api to the latest version

Why: Because in the new version there is a fix for the issue.

The update will solve a problem where title should be ignored when is empty while using name option

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8a37eee:

Sandbox Source
kentcdodds/react-testing-library-examples Configuration
trusting-neumann-26de8 Issue #747
react-testing-library demo Issue #747

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #748 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #748   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          657       657           
  Branches       173       173           
=========================================
  Hits           657       657           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe04b50...8a37eee. Read the comment docs.

@eps1lon eps1lon changed the title chore: update dom-accessibility-api fix: update dom-accessibility-api Aug 20, 2020
@eps1lon eps1lon merged commit 1bcf60e into testing-library:master Aug 20, 2020
@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.22.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marcosvega91 marcosvega91 deleted the pr/update_dep_dom_acc_api branch August 20, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getByRole can't find button by name if title is ""
3 participants