-
Notifications
You must be signed in to change notification settings - Fork 470
feat(role): support {pressed: true}
for buttons
#729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(role): support {pressed: true}
for buttons
#729
Conversation
Hat tip to Sebastian Silbermann for his prior work on PR testing-library#692
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b48e4f:
|
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 651 657 +6
Branches 170 173 +3
=========================================
+ Hits 651 657 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful :chefs-kiss: thanks!
@all-contributors please add @jluxenberg for code and tests |
I've put up a pull request to add @jluxenberg! 🎉 |
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
🎉 This PR is included in version 7.22.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@kentcdodds FYI I didn't realize the docs site was separate; I'm opening a PR for the update to the docs now. |
Great, thank you! |
Hat tip to Sebastian Silbermann for his prior work on PR #692
What: Adds support for querying based on
aria-pressed
state for elements with a role of "button" (see https://www.w3.org/TR/wai-aria-1.1/#aria-pressed)Why:
aria-checked
andaria-selected
area already supported; adding the ability to query byaria-pressed
should round out support for querying by these types of parameters.How: This is implemented in exactly the same fashion as Sebastian Silbermann's implementation in PR #692.
Checklist:
docs site