Skip to content

feat: Add SASL/SCRAM and IAM access control TCP ports for Kafka / MSK #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2022
Merged

feat: Add SASL/SCRAM and IAM access control TCP ports for Kafka / MSK #254

merged 6 commits into from
Aug 23, 2022

Conversation

@aidanmelen
Copy link
Contributor

@aidanmelen aidanmelen commented Aug 20, 2022 •
edited by antonbabenko
Loading

Adding rules for all AWS MSK ports: https://docs.aws.amazon.com/msk/latest/developerguide/port-info.html

Completion of @dhoppe's PR

Closes #248

Fixes #244

@aidanmelen aidanmelen changed the title All MSK rules feat: All MSK rules Aug 20, 2022
@aidanmelen
Copy link
Contributor Author

aidanmelen commented Aug 20, 2022

@antonbabenko Thanks for all your awesome work maintaining these AWS modules. Glad we get to contribute! This PR is now ready for review

@aidanmelen
Copy link
Contributor Author

aidanmelen commented Aug 20, 2022

I ran pre-commit run -a and the update_groups.sh script.

@aidanmelen aidanmelen mentioned this pull request Aug 20, 2022
Closed
1 task
@antonbabenko antonbabenko changed the title feat: All MSK rules feat: Add SASL/SCRAM and IAM access control TCP ports for Kafka / MSK Aug 22, 2022
@antonbabenko
Copy link
Member

antonbabenko commented Aug 22, 2022 •
edited
Loading

@aidanmelen I don't have permission to push to your fork but I wanted to commit changes after pre-commit run -a to make GitHub CI green. Please run this command yourself and commit changes in 3 README.md files.

@aidanmelen
Copy link
Contributor Author

aidanmelen commented Aug 22, 2022 •
edited
Loading

@antonbabenko I added you as a collaborator to my branch

@antonbabenko antonbabenko mentioned this pull request Aug 23, 2022
Closed
@antonbabenko
Copy link
Member

antonbabenko commented Aug 23, 2022

Great job, @aidanmelen @dhoppe ! It's time to merge and release :)

@antonbabenko antonbabenko merged commit c254255 into terraform-aws-modules:master Aug 23, 2022
antonbabenko pushed a commit that referenced this pull request Aug 23, 2022
@semantic-release-bot
chore(release): version 4.13.0 [skip ci]
c0d92f5 
## [4.13.0](v4.12.0...v4.13.0) (2022-08-23)

### Features

* Add SASL/SCRAM and IAM access control TCP ports for Kafka / MSK ([#254](#254)) ([c254255](c254255))
@antonbabenko
Copy link
Member

antonbabenko commented Aug 23, 2022

This PR is included in version 4.13.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 15, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port TCP/9096 not available

3 participants

@aidanmelen @antonbabenko @dhoppe