Skip to content

Conversation

@bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Oct 18, 2025

Description

  • Update CI workflow versions to latest
  • Update pre-commit versions to latest
  • Align and standardize .gitignore with other modules
  • Add rmz to speed up unnecessary file removal in GitHub CI environment. There is now a conditional for the pre-commit run -a step (named Max TF pre-commit in the GitHub UI) that will delete more files for the security group module since it will consume a lot of space due to all the sub-modules. Otherwise we remove just enough in the quickest fashion to get on with business.

Motivation and Context

  • Updates our workflows to use the latest versions
  • Standardize common CI files across modules so we can "automate" updates in the future (right now it just a bash script on my local machine)

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and all other PRs look good to me, but they are marked as drafts. Feel free to merge them, or assign me as a reviewer if you want me to take a look at them.

@bryantbiggs
Copy link
Member Author

@antonbabenko theres a few repos that I'll need to make some manual tweaks but wanted to get your thoughts on the changes before proceeding. Specifically, moving the changelog and the config for the automatic release generation to docs/ to clean up and simplify the project root

@bryantbiggs
Copy link
Member Author

and FYI - I updated the release workflow and validated here terraform-aws-modules/terraform-aws-eks@master...clowdhaus:terraform-aws-eks:master to ensure its working as intended

@antonbabenko
Copy link
Member

I like that the resulting CHANGELOG, as well as other config files (pre-commit, releaserc), is in the root. This is the default location for such things. I also like that "docs" folder contains more specific docs (by human) and CHANGELOG (by script) is in the root. I would not change it.

@bryantbiggs bryantbiggs marked this pull request as ready for review October 20, 2025 15:45
@antonbabenko antonbabenko merged commit feb4561 into terraform-aws-modules:master Oct 21, 2025
31 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 21, 2025
## [8.1.1](v8.1.0...v8.1.1) (2025-10-21)

### Bug Fixes

* Update CI workflow versions to latest ([#713](#713)) ([feb4561](feb4561))
@antonbabenko
Copy link
Member

This PR is included in version 8.1.1 🎉

@bryantbiggs bryantbiggs deleted the chore/update-ci-workflow-versions branch October 21, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants