Skip to content

Conversation

jschilperoord
Copy link
Contributor

@jschilperoord jschilperoord commented Apr 1, 2022

Description

Make it possible to pass the authorization_scopes as a comma separated string on the integration level. Passing it as a set of string like the AWS resource expects makes the variable validation fail with a " attribute types must all match for conversion to map" as also described here

Motivation and Context

Due to missing documentation on the AWS provider the authorization_scopes parameter was being ignored. The docs have been updated as seen here
This fixes issue

Breaking Changes

No. This is an optional parameter

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@jschilperoord jschilperoord changed the title Add support for passing authorization_scopes on routes with JWT authorizer fix: Add support for passing authorization_scopes on routes with JWT authorizer Apr 1, 2022
@antonbabenko antonbabenko merged commit c2b8d6b into terraform-aws-modules:master Apr 1, 2022
antonbabenko pushed a commit that referenced this pull request Apr 1, 2022
### [1.6.1](v1.6.0...v1.6.1) (2022-04-01)

### Bug Fixes

* Add support for passing authorization_scopes on routes with JWT authorizer ([#67](#67)) ([c2b8d6b](c2b8d6b))
@antonbabenko
Copy link
Member

This PR is included in version 1.6.1 🎉

@tim0git
Copy link

tim0git commented Apr 1, 2022

Amazing work, works like a dream! Thank you all.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing authorization_scopes to integration configuration

3 participants