Skip to content

added new core members #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

hanneshapke
Copy link
Contributor

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@github-actions
Copy link
Contributor

Thanks for the PR! 🚀

Instructions: Approve using /lgtm and mark for automatic merge by using /merge.

@casassg
Copy link
Member

casassg commented Oct 12, 2022

/lgtm We will need @rcrowe-google to review this

CODEOWNERS Outdated
Comment on lines 4 to 13
# SIG operations: proposals and contributions guidelines
/proposals/ @rcrowe-google
/CONTRIBUTING.md @rcrowe-google @casassg @hanneshapke
/CONTRIBUTING.md @rcrowe-google @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki
/README.md @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki

# PyPi distribution files
/tfx_addons/__init__.py @casassg @hanneshapke
/tfx_addons/version.py @casassg @hanneshapke
/setup.py @casassg @hanneshapke
/pyproject.toml @casassg @hanneshapke
/README.md @casassg @hanneshapke
/tfx_addons/__init__.py @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki
/tfx_addons/version.py @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki
/setup.py @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki
/pyproject.toml @casassg @hanneshapke @codesue @deutranium @wihanbooyse @BACtaki
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we add a comment about this being core members

Copy link
Collaborator

@rcrowe-google rcrowe-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rcrowe-google rcrowe-google removed the request for review from theadactyl October 18, 2022 01:18
@rcrowe-google
Copy link
Collaborator

/lgtm
/merge

@github-actions github-actions bot merged commit f043f9e into tensorflow:main Oct 18, 2022
@github-actions
Copy link
Contributor

Merged with approvals from rcrowe-google - thanks for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants