Skip to content

Commit f3e6c7f

Browse files
authored
Fix app.js (#6727)
BUG
1 parent ad7bfe5 commit f3e6c7f

File tree

1 file changed

+6
-4
lines changed
  • e2e/benchmarks/browserstack-benchmark

1 file changed

+6
-4
lines changed

e2e/benchmarks/browserstack-benchmark/app.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ async function benchmarkAll(config) {
125125
}
126126
}
127127
console.log('\nAll benchmarks complete!');
128-
endFirebaseInstance();
129128
return allResults;
130129
}
131130

@@ -168,9 +167,9 @@ async function benchmark(config, runOneBenchmark = getOneBenchmarkResult) {
168167
for (const tabId in config.browsers) {
169168
results.push(promiseQueue.add(() => {
170169
return runOneBenchmark(tabId, cliArgs?.maxTries).then((value) => {
171-
value.deviceInfo = config.browsers[tabId];
172-
value.modelInfo = config.benchmark;
173-
return value;
170+
value.deviceInfo = config.browsers[tabId];
171+
value.modelInfo = config.benchmark;
172+
return value;
174173
});
175174
}));
176175
}
@@ -404,6 +403,9 @@ async function prebenchmarkSetup() {
404403
`Please provide a valid path.`);
405404
}
406405
}
406+
if (cliArgs.firestore) {
407+
endFirebaseInstance();
408+
}
407409
}
408410

409411
/* Only run this code if app.js is called from the command line */

0 commit comments

Comments
 (0)