Skip to content

Commit f06434a

Browse files
author
Kangyi Zhang
authored
[tfjs-node] Add new line when saving package.json through code (#2168)
INTERNAL * fix nit * fs.writeFileSync throw error
1 parent 1c25b56 commit f06434a

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

tfjs-node/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,4 @@
6767
4
6868
]
6969
}
70-
}
70+
}

tfjs-node/scripts/install.js

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -65,21 +65,13 @@ async function setPackageJsonFile() {
6565
async function updateAddonName() {
6666
packageJsonFile['binary']['package_name'] = addonName;
6767
const stringFile = JSON.stringify(packageJsonFile, null, 2);
68-
fs.writeFile((`${__dirname}/../package.json`), stringFile, err => {
69-
if (err) {
70-
console.log('Faile to update addon name in package.json: ' + err);
71-
}
72-
});
68+
fs.writeFileSync((`${__dirname}/../package.json`), stringFile);
7369
}
7470

7571
async function revertAddonName() {
7672
delete packageJsonFile['binary']['package_name'];
77-
const stringFile = JSON.stringify(packageJsonFile, null, 2);
78-
fs.writeFile((`${__dirname}/../package.json`), stringFile, err => {
79-
if (err) {
80-
console.log('Faile to update addon name in package.json: ' + err);
81-
}
82-
});
73+
const stringFile = JSON.stringify(packageJsonFile, null, 2).concat('\n');
74+
fs.writeFileSync((`${__dirname}/../package.json`), stringFile);
8375
}
8476

8577
/**

0 commit comments

Comments
 (0)