Change conv2d to match TF API

[dsmilkov]

This fixes #106

This change is 

[nsthorat]

---

Reviewed 3 of 12 files at r1, 16 of 16 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

src/math/conv_util.ts, line 23 at r2 (raw file):

};

export function computeOutputInfo(

can you write a couple unit tests for this? it's a well defined function

---

src/math/math.ts, line 901 at r2 (raw file):

   * @param bias Optional bias, rank 1 of shape [outDepth].
   * @param strides The strides of the convolution: [strideHeight, strideWidth].
   * @param pad A string from: 'same', 'valid'. The type of padding algorithm.

or a number.

Can you briefly explain what SAME | VALID actually means? the naming is confusing to begin with, but a simple jsdoc here would be really nice

---

src/math/math.ts, line 1407 at r2 (raw file):

  let param2: number;
  if (typeof param === 'number') {
    param1 = param;

why not shorten this whole thing

if (typeof param === 'number') { return [param, param]; } return param;

---

Comments from Reviewable

[dsmilkov]

Reviewed 1 of 12 files at r1.
Review status: 1 of 26 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

---

src/math/conv_util.ts, line 23 at r2 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

can you write a couple unit tests for this? it's a well defined function

done.

---

src/math/math.ts, line 901 at r2 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

or a number.

Can you briefly explain what SAME | VALID actually means? the naming is confusing to begin with, but a simple jsdoc here would be really nice

Done.

---

src/math/math.ts, line 1407 at r2 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

why not shorten this whole thing

if (typeof param === 'number') { return [param, param]; } return param;

oh jeez ups :) made it one-liner. I can't program simple things anymore. only glsl...

---

Comments from Reviewable