This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Remove non-nullable "!" operator #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 20 of 21 files at r1. Comments from Reviewable |
|
Reviewed 1 of 21 files at r1. Comments from Reviewable |
mnottheone
pushed a commit
to mnottheone/deeplearnjs
that referenced
this pull request
Dec 1, 2018
* Remove non-nullable "!" operator * fix lint errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-nullable operator is not needed anymore, since we are not using
strictModefor the typescript compiler. This PR removes all occurrences of ! as this confuses users (see #59), and makes porting code to plain JavaScript more difficult.This change is