Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Commit 893ba6e

Browse files
author
Nikhil Thorat
authored
Add a setter for MAX_TEXTURE_SIZE so the property can be modifi… (#1868)
BUG
1 parent 6e6bd19 commit 893ba6e

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

src/backends/webgl/flags_webgl_test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ describe('WEBGL_CONV_IM2COL', () => {
195195
describe('WEBGL_MAX_TEXTURE_SIZE', () => {
196196
beforeEach(() => {
197197
ENV.reset();
198-
webgl_util.MAX_TEXTURE_SIZE = null;
198+
webgl_util.resetMaxTextureSize();
199199

200200
spyOn(canvas_util, 'getWebGLContext').and.returnValue({
201201
MAX_TEXTURE_SIZE: 101,
@@ -209,7 +209,7 @@ describe('WEBGL_MAX_TEXTURE_SIZE', () => {
209209
});
210210
afterAll(() => {
211211
ENV.reset();
212-
webgl_util.MAX_TEXTURE_SIZE = null;
212+
webgl_util.resetMaxTextureSize();
213213
});
214214

215215
it('is a function of gl.getParameter(MAX_TEXTURE_SIZE)', () => {
@@ -221,7 +221,7 @@ describe('WEBGL_MAX_TEXTURES_IN_SHADER', () => {
221221
let maxTextures: number;
222222
beforeEach(() => {
223223
ENV.reset();
224-
webgl_util.MAX_TEXTURES_IN_SHADER = null;
224+
webgl_util.resetMaxTexturesInShader();
225225

226226
spyOn(canvas_util, 'getWebGLContext').and.callFake(() => {
227227
return {
@@ -237,7 +237,7 @@ describe('WEBGL_MAX_TEXTURES_IN_SHADER', () => {
237237
});
238238
afterAll(() => {
239239
ENV.reset();
240-
webgl_util.MAX_TEXTURES_IN_SHADER = null;
240+
webgl_util.resetMaxTexturesInShader();
241241
});
242242

243243
it('is a function of gl.getParameter(MAX_TEXTURE_IMAGE_UNITS)', () => {

src/backends/webgl/webgl_util.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,8 +498,8 @@ export function isReshapeFree(shape1: number[], shape2: number[]): boolean {
498498
// We cache webgl params because the environment gets reset between
499499
// unit tests and we don't want to constantly query the WebGLContext for
500500
// MAX_TEXTURE_SIZE.
501-
export let MAX_TEXTURE_SIZE: number;
502-
export let MAX_TEXTURES_IN_SHADER: number;
501+
let MAX_TEXTURE_SIZE: number;
502+
let MAX_TEXTURES_IN_SHADER: number;
503503

504504
export function getWebGLMaxTextureSize(webGLVersion: number): number {
505505
if (MAX_TEXTURE_SIZE == null) {
@@ -509,6 +509,13 @@ export function getWebGLMaxTextureSize(webGLVersion: number): number {
509509
return MAX_TEXTURE_SIZE;
510510
}
511511

512+
export function resetMaxTextureSize() {
513+
MAX_TEXTURE_SIZE = null;
514+
}
515+
export function resetMaxTexturesInShader() {
516+
MAX_TEXTURES_IN_SHADER = null;
517+
}
518+
512519
export function getMaxTexturesInShader(webGLVersion: number): number {
513520
if (MAX_TEXTURES_IN_SHADER == null) {
514521
const gl = getWebGLContext(webGLVersion);

0 commit comments

Comments
 (0)