rust: define blob key encoding #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The data provider RPC protocol requires servers to emit “blob keys”, opaque, URL-safe tokens that uniquely identify blobs. This patch defines an in-memory `BlobKey` struct with encoding and decoding. The wire format is URL-safe base64 (with no padding) over JSON. The seemingly unrelated changes are needed because loading `serde_json` adds trait implementations that make some type inference inadmissible: <rust-lang/rust#80964> Test Plan: Unit tests included. wchargin-branch: rust-blob-keys wchargin-source: bd9d325a73fb7757b2916e52a72c4e23255c51ed
wchargin-branch: rust-blob-keys wchargin-source: 7304b8f1f4e401a934083c5f25bba2a02fc42c61
stephanwlee
approved these changes
Jan 13, 2021
tensorboard/data/server/blob_key.rs
Outdated
| fn test_bad_json() { | ||
| match "AAAAAA".parse::<BlobKey>().unwrap_err() { | ||
| ParseBlobKeyError::BadJson(_) => (), | ||
| other => panic!("expected BadBase64(_), got {:?}", other), |
wchargin-branch: rust-blob-keys wchargin-source: 9e65e8c74746e97e09f5213d46d6d2a022d49af6
wchargin-branch: rust-blob-keys wchargin-source: 9e65e8c74746e97e09f5213d46d6d2a022d49af6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The data provider RPC protocol requires servers to emit “blob keys”,
opaque, URL-safe tokens that uniquely identify blobs. This patch defines
an in-memory
BlobKeystruct with encoding and decoding. The wireformat is URL-safe base64 (with no padding) over JSON.
The seemingly unrelated changes are needed because loading
serde_jsonadds trait implementations that make some type inference inadmissible:
rust-lang/rust#80964
Test Plan:
Unit tests included.
wchargin-branch: rust-blob-keys