This repository was archived by the owner on Apr 23, 2025. It is now read-only.
[WordSeg] Fix pullback for Array.update(at:to:).
#653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pullback of `Array.update(at:to:)` resets `dSelf.base[index]` to a zero value. For correctness, it should use the value of `self[index].zeroTangentVector` before the update occurs, not `dElement.zeroTangentVector`.
marcrasi
approved these changes
Jul 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pullback of
Array.update(at:to:)resetsdSelf.base[index]to a zero value.For correctness, it should use the value of
self[index].zeroTangentVectorbeforethe update occurs, not
dElement.zeroTangentVector.Fixes
WordSegProbeLayerTests.testProbeEncoderafter the2020-07-28 master -> merge.Previously, the test passed due to an incorrect definition of
Array.TangentVector.zeroTangentVectorInitializer, which was fixed in swiftlang/swift#32948.