Skip to content
This repository was archived by the owner on Jul 15, 2018. It is now read-only.

add Quit method to Service interface #150

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Feb 12, 2018

remove deprecated QuitService

Refs #114

remove deprecated QuitService
@melekes melekes requested review from jaekwon and removed request for zramsay February 12, 2018 07:41
@codecov-io
Copy link

codecov-io commented Feb 12, 2018

Codecov Report

Merging #150 into develop will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #150      +/-   ##
===========================================
+ Coverage    62.67%   62.72%   +0.04%     
===========================================
  Files           58       58              
  Lines         4236     4233       -3     
===========================================
  Hits          2655     2655              
+ Misses        1368     1365       -3     
  Partials       213      213
Impacted Files Coverage Δ
common/service.go 55.55% <66.66%> (+2.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ce4c2...a57340f. Read the comment docs.

@ebuchman ebuchman merged commit c858b3b into develop Feb 12, 2018
@ebuchman ebuchman deleted the tm-1205-add-quit-method-to-service branch February 12, 2018 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants