fix(subnet-group): update ram-share module

Author: posquit0

modules/subnet-group/README.md

@@ -27,14 +27,14 @@ This module creates following resources.
 
 | Name | Version |
 |------|---------|
-| <a name="provider_aws"></a> [aws](#provider\_aws) | 6.18.0 |
+| <a name="provider_aws"></a> [aws](#provider\_aws) | 6.20.0 |
 
 ## Modules
 
 | Name | Source | Version |
 |------|--------|---------|
 | <a name="module_resource_group"></a> [resource\_group](#module\_resource\_group) | tedilabs/misc/aws//modules/resource-group | ~> 0.12.0 |
-| <a name="module_share"></a> [share](#module\_share) | tedilabs/organization/aws//modules/ram-share | ~> 0.4.0 |
+| <a name="module_share"></a> [share](#module\_share) | tedilabs/organization/aws//modules/ram-share | ~> 0.5.0 |
 
 ## Resources
 

modules/subnet-group/ram-share.tf

@@ -1,10 +1,19 @@
+locals {
+  ram_share_name_prefix = join(".", [
+    "vpc",
+    "subnet-group",
+    replace(var.name, "/[^a-zA-Z0-9_\\.-]/", "-"),
+  ])
+}
+
+
 ###################################################
 # Resource Sharing by RAM (Resource Access Manager)
 ###################################################
 
 module "share" {
   source  = "tedilabs/organization/aws//modules/ram-share"
-  version = "~> 0.4.0"
+  version = "~> 0.5.0"
 
   for_each = {
     for share in var.shares :
@@ -13,9 +22,12 @@ module "share" {
 
   region = values(aws_subnet.this)[0].region
 
-  name = "vpc.subnet-group.${var.name}.${each.key}"
+  name = "${local.ram_share_name_prefix}.${each.key}"
 
-  resources = values(aws_subnet.this)[*].arn
+  resources = {
+    for name, subnet in aws_subnet.this :
+    name => subnet.arn
+  }
 
   permissions = each.value.permissions