Remove default value for TARANTOOL_CLUSTER_COOKIE
#104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix use default value for `TARANTOOL_CLUSTER_COOKIE` - CHANGELOG.md Closes #55
Closed
ArtDu
changed the title
TARANTOOL_CLUSTER_COOKIETARANTOOL_CLUSTER_COOKIE
ArtDu
changed the title
TARANTOOL_CLUSTER_COOKIETARANTOOL_CLUSTER_COOKIE
bitgorbovsky
requested changes
Dec 14, 2023
src/main/java/org/testcontainers/containers/TarantoolCartridgeContainer.java
Outdated
Show resolved
Hide resolved
ArtDu
requested changes
Dec 14, 2023
src/main/java/org/testcontainers/containers/TarantoolCartridgeContainer.java
Outdated
Show resolved
Hide resolved
ArtDu
previously approved these changes
Dec 14, 2023
Closes #55
ArtDu
approved these changes
Dec 14, 2023
bitgorbovsky
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TARANTOOL_CLUSTER_COOKIEenv variable in cartridge container.Now it works like in cartridge in order of decreasing priority as directed by the user:
TARANTOOL_CLUSTER_COOKIE > cartridge.cfg > default_cookieYou can set TARANTOOL_CLUSTER_COOKIE by build-arg on image building or by env arg before container starting
(#55)
testapp-cluster-cookietosecret-cluster-cookie(#55)I haven't forgotten about:
Related issues:
Closes #55