Skip to content

Check Lua source code with luacheck #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ligurio opened this issue Nov 19, 2020 · 1 comment · Fixed by #179
Closed

Check Lua source code with luacheck #178

ligurio opened this issue Nov 19, 2020 · 1 comment · Fixed by #179
Labels
luacheck

Comments

@ligurio
Copy link
Member

ligurio commented Nov 19, 2020 •
edited
Loading 

Checking test-run/lib/tarantool-python/test-run/lib/tarantool-python/tests/suites/box.lua 1 warning

    test-run/lib/tarantool-python/test-run/lib/tarantool-python/tests/suites/box.lua:2:1: (W121) setting read-only global variable os

Tarantool issue: tarantool/tarantool#4681
ligurio added a commit that referenced this issue Nov 19, 2020
@ligurio
Fix luacheck warning
762f5df 
Closes #178
@ligurio ligurio reopened this Nov 19, 2020
@ligurio
Copy link
Member Author

ligurio commented Nov 19, 2020

Closed accidentally, reopened.

@ligurio ligurio mentioned this issue Nov 19, 2020
Merged
ligurio added a commit to tarantool/test-run that referenced this issue Nov 19, 2020
@ligurio
Add luacheck config and fix warnings found by luacheck
2cdc3d1 
- removed statement with info variable as it is unused
- luacheck contains same global supressions
  as config in tarantool repository
- path with tarantool-python is excluded until [1] is open

1. tarantool/tarantool-python#178

Part of #208
Totktonada pushed a commit to tarantool/test-run that referenced this issue Nov 19, 2020
@ligurio @Totktonada
Add luacheck config and fix warnings found by luacheck
daff045 
- removed statement with info variable as it is unused
- luacheck contains same global supressions
  as config in tarantool repository
- path with tarantool-python is excluded until [1] is open

1. tarantool/tarantool-python#178

Part of #208
Totktonada pushed a commit that referenced this issue Nov 19, 2020
@ligurio @Totktonada
Fix luacheck warnings
97f845e 
Closes #178
Totktonada pushed a commit that referenced this issue Nov 19, 2020
@ligurio @Totktonada
Fix luacheck warnings
4aaadb9 
Closes #178
@ligurio ligurio mentioned this issue Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
luacheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix luacheck warning tarantool/tarantool-python
1 participant
@ligurio