Skip to content

Add minimal support of Connection.*ClientInfo() #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2019
Merged

Add minimal support of Connection.*ClientInfo() #191

merged 2 commits into from
Jun 12, 2019

Conversation

nicktorwald
Copy link

At present, the driver doesn't support any properties and must retrieve
empty data instead of raising an error with an exception for
Statement.setClientInfo which will throw ClientInfoException for any
attempts to set a property.

Closes: #74

@coveralls
Copy link

coveralls commented May 22, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 71.804% when pulling 4b3d4a9 on nicktorwald/gh-74-connection-client-info into 762ce2f on master.

@nicktorwald nicktorwald requested a review from Totktonada May 22, 2019 15:55
Totktonada
Totktonada approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Totktonada
Copy link
Member

The only comment: you write Statement.*ClientInfo() in the commit message and the PR header. It should be Connection.*ClientInfo().

@nicktorwald nicktorwald changed the title Add minimal support of Statement.*ClientInfo() Add minimal support of Connection.*ClientInfo() Jun 4, 2019
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-74-connection-client-info branch from 8fba046 to 4b3d4a9 Compare June 4, 2019 16:57
@nicktorwald
Add metadata table columns for the methods which return ResultSet with
25b156d 
a predefined structure.
@nicktorwald
Add minimal support of Connection.*ClientInfo()
828c312 
At present, the driver doesn't support any properties and must retrieve
empty data instead of raising an error with an exception for
Statement.setClientInfo which will throw ClientInfoException for any
attempts to set a property.

Closes: #74
@nicktorwald nicktorwald force-pushed the nicktorwald/gh-74-connection-client-info branch from 4b3d4a9 to 828c312 Compare June 12, 2019 18:07
@nicktorwald nicktorwald merged commit 6f620ce into master Jun 12, 2019
@nicktorwald nicktorwald deleted the nicktorwald/gh-74-connection-client-info branch June 12, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jdbc: Support Connection.getClientInfo() and setClientInfo() methods
3 participants
@nicktorwald @coveralls @Totktonada