Skip to content

Add an option to install nightly build #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

Add an option to install nightly build #16

merged 1 commit into from
Aug 4, 2021

Conversation

rosik
Copy link
Contributor

@rosik rosik commented Aug 3, 2021 

steps:
  - uses: actions/checkout@v2
  - uses: tarantool/setup-tarantool@v1
    with:
      tarantool-version: '2.6'
      nightly-build: true

Close #9

@rosik rosik requested review from Totktonada and Steap2448 August 3, 2021 18:25
Totktonada
Totktonada reviewed Aug 3, 2021
View reviewed changes
src/main.ts
const baseUrl =
'https://download.tarantool.org/tarantool/release/' +
'https://download.tarantool.org/tarantool/' +
(nightlyBuild ? '' : 'release/') +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is explicit 'live' URL part, if you want.

In the next bullets 2 and 3 are equal, but the latter is more explicit.

  1. https://download.tarantool.org/tarantool/release/<...>
  2. https://download.tarantool.org/tarantool/live/<...>
  3. https://download.tarantool.org/tarantool/<...>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Accepted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trick didn't work:

$ curl -v https://download.tarantool.org/tarantool/live/1.10/gpgkey

HTTP/1.1 302 Moved Temporarily
Location: https://www.tarantool.io/download/

I'll merge without it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the bug. Sorry. Okay.

Totktonada
Totktonada approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems.

@rosik rosik force-pushed the 9-nightly-repo branch 4 times, most recently from 8dbd24c to b5a319d Compare August 4, 2021 11:27
@rosik rosik merged commit 7112e91 into master Aug 4, 2021
@rosik rosik deleted the 9-nightly-repo branch August 4, 2021 12:11
@Totktonada Totktonada mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

@Steap2448 Steap2448 Steap2448 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support live repositories (per push tarantool builds)
3 participants
@rosik @Totktonada @Steap2448