Add the "lazy start" technique to initialization stage #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The similar problem: tarantool/expirationd#37 |
LeonidVas
force-pushed
the
lvasiliev/gh-122-work-with-read-only-mode
branch
from
587c7a7 to
786c94f
Compare
Totktonada
reviewed
Sep 25, 2020
LeonidVas
force-pushed
the
lvasiliev/gh-122-work-with-read-only-mode
branch
from
786c94f to
7e982eb
Compare
When the script is long enough to contain multiple function, it's nice to have a function like "main" instead of just a linear flow code. The patch moves the initialization code of the queue module into a separate function.
LeonidVas
force-pushed
the
lvasiliev/gh-122-work-with-read-only-mode
branch
from
7e982eb to
5c3f452
Compare
Mons
suggested changes
Oct 13, 2020
Previously, if an instance was started in read_only mode, it could throw an error when initializing the queue module, like this: "Can't modify data because this instance is in read-only mode". To avoid such behavior the "lazy start" technique has been added: The queue module is loaded immediately if the instance was configured with read_only = false. Otherwise, a start is delayed until the instance will be configured with read_only = false. Closes #122
LeonidVas
force-pushed
the
lvasiliev/gh-122-work-with-read-only-mode
branch
from
5c3f452 to
6dc58a7
Compare
Mons
approved these changes
Oct 15, 2020
Totktonada
reviewed
Oct 15, 2020
Totktonada
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
I cannot say that I'm comfortable with complexity we have there, but I don't want to push Leonid to experiment around different similar variants (given one with the __call metamethod replacing, with a proxy table whose __call invokes a real reconfiguration function, with registering a callback using box.on_reload_configuration) to understand what will looks better.
Since it should resolve the issue and I don't see anything that would lead to problems in use, it is okay for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an instance was started in read_only mode,
it could throw an error when initializing the queue module,
like this: "Can't modify data because this instance is in
read-only mode".
To avoid such behavior the "lazy start" technique has been added:
The queue module is loaded immediately if the instance was
configured with read_only = false. Otherwise, a start is delayed
until the instance will be configured with read_only = false.
Closes #122
ChangeLog: add the ability to start an instance with a loaded queue module in read-only mode. In this case, a start of the module will be delayed until the instance will be configured with read_only = false.