Add driver API check #129
Merged
Add driver API check #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonidVas
force-pushed
the
lvasiliev/gh-126-fail-gracefully
branch
from
ebf37f9 to
8a3bf9e
Compare
Totktonada
reviewed
Aug 12, 2020
LeonidVas
force-pushed
the
lvasiliev/gh-126-fail-gracefully
branch
from
8a3bf9e to
8faec74
Compare
Totktonada
approved these changes
Aug 13, 2020
In addition to the core queue drivers, customer drivers are exists. In the commit a check for a driver API implementation was added. Now, the consumer will be informed about the missing methods in the driver implementation. Closes #126
LeonidVas
force-pushed
the
lvasiliev/gh-126-fail-gracefully
branch
from
8faec74 to
03701f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the core queue drivers, customer drivers are exists. In the commit a check for a driver API implementation was added. Now, the consumer will be informed about the missing methods in the driver implementation.
Closes #126
ChangeLog: added notification about missing methods in the driver implementation.
ReleaseNotes: the "tasks_by_state" method was added to the driver API. See example implementation in one of the core drivers.